#11 tdewallet not working anymore

Closed
opened 11 months ago by deloptes · 6 comments

Basic information

I found that the error is coming from tdelibs, so referring here to the issue

see TDE/tdeutils#6

<!-- This is a comment. Please fill in the required fields below. The comments provide instructions on how to do so. Note: You do not need to remove comments. --> ## Basic information I found that the error is coming from tdelibs, so referring here to the issue see https://mirror.git.trinitydesktop.org/gitea/TDE/tdeutils/issues/6
deloptes commented 11 months ago
Poster

The place

    passhash.fill(0);        // passhash is UNUSABLE NOW

    const char *t = encrypted.data();

    // strip the leading data
    t += blksz;    // one block of random data

    // strip the file size off
    long fsize = 0;

    fsize |= (long(*t) << 24) & 0xff000000;
    t++;
    fsize |= (long(*t) << 16) & 0x00ff0000;
    t++;
    fsize |= (long(*t) <<  8) & 0x0000ff00;
    t++;
    fsize |= long(*t) & 0x000000ff;
    t++;

    if (fsize < 0 || fsize > long(encrypted.size()) - blksz - 4) {
        //kdDebug() << "fsize: " << fsize << " encrypted.size(): " << encrypted.size() << " blksz: " << blksz << endl;
        encrypted.fill(0);
        return -9;         // file structure error.
    }

when commenting out the kdDebug row I get a large number for fsize, while encrypted size looks good. blksz is 8

The place ``` passhash.fill(0); // passhash is UNUSABLE NOW const char *t = encrypted.data(); // strip the leading data t += blksz; // one block of random data // strip the file size off long fsize = 0; fsize |= (long(*t) << 24) & 0xff000000; t++; fsize |= (long(*t) << 16) & 0x00ff0000; t++; fsize |= (long(*t) << 8) & 0x0000ff00; t++; fsize |= long(*t) & 0x000000ff; t++; if (fsize < 0 || fsize > long(encrypted.size()) - blksz - 4) { //kdDebug() << "fsize: " << fsize << " encrypted.size(): " << encrypted.size() << " blksz: " << blksz << endl; encrypted.fill(0); return -9; // file structure error. } ``` when commenting out the kdDebug row I get a large number for fsize, while encrypted size looks good. blksz is 8
MicheleC added the
SL/major
label 11 months ago
MicheleC commented 11 months ago
Owner

Just a thought. This could potentially be related/caused/be a consequence of the changes made some weeks ago for KPasswordEdit (see bug 2961)

Just a thought. This could potentially be related/caused/be a consequence of the changes made some weeks ago for KPasswordEdit (see bug 2961)
MicheleC added this to the R14.1.0 release milestone 11 months ago
MicheleC commented 11 months ago
Owner

I can reproduce the problem here. I will work on that.

I can reproduce the problem here. I will work on that.
MicheleC self-assigned this 11 months ago
deloptes commented 11 months ago
Poster

This is what I get here:

kded: fsize: 4009754624
kded: fsize: 4025155584
kded: fsize: 4025179136
kded: fsize: 4025179308
kded: fsize: 4025179308 encrypted.size(): 33472 blksz: 8

from

    fsize |= (long(*t) << 24) & 0xff000000;
    kdDebug() << "fsize: " << fsize << endl;
    t++;
    fsize |= (long(*t) << 16) & 0x00ff0000;
    kdDebug() << "fsize: " << fsize << endl;
    t++;
    fsize |= (long(*t) <<  8) & 0x0000ff00;
    kdDebug() << "fsize: " << fsize << endl;
    t++;
    fsize |= long(*t) & 0x000000ff;
    kdDebug() << "fsize: " << fsize << endl;
    t++;

    if (fsize < 0 || fsize > long(encrypted.size()) - blksz - 4) {
        kdDebug() << "fsize: " << fsize << " encrypted.size(): " << encrypted.size() << " blksz: " << blksz << endl;
        encrypted.fill(0);
        return -9;         // file structure error.
    }

I hope this helps

Thank you in advance

This is what I get here: ``` kded: fsize: 4009754624 kded: fsize: 4025155584 kded: fsize: 4025179136 kded: fsize: 4025179308 kded: fsize: 4025179308 encrypted.size(): 33472 blksz: 8 ``` from ``` fsize |= (long(*t) << 24) & 0xff000000; kdDebug() << "fsize: " << fsize << endl; t++; fsize |= (long(*t) << 16) & 0x00ff0000; kdDebug() << "fsize: " << fsize << endl; t++; fsize |= (long(*t) << 8) & 0x0000ff00; kdDebug() << "fsize: " << fsize << endl; t++; fsize |= long(*t) & 0x000000ff; kdDebug() << "fsize: " << fsize << endl; t++; if (fsize < 0 || fsize > long(encrypted.size()) - blksz - 4) { kdDebug() << "fsize: " << fsize << " encrypted.size(): " << encrypted.size() << " blksz: " << blksz << endl; encrypted.fill(0); return -9; // file structure error. } ``` I hope this helps Thank you in advance
MicheleC commented 11 months ago
Owner

Thanks Emanoil, I will update here as soon as I have a fix for the issue. These days are quite busy so I have just a little time for TDE each day, so I may be a bit slow :disappointed:

Thanks Emanoil, I will update here as soon as I have a fix for the issue. These days are quite busy so I have just a little time for TDE each day, so I may be a bit slow :disappointed:
MicheleC commented 11 months ago
Owner

Fixed by PR #14

Fixed by PR #14
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.