tdewallet not working anymore #11

Basic information

I found that the error is coming from tdelibs, so referring here to the issue

The place

	passhash.fill(0);        // passhash is UNUSABLE NOW

	const char *t = encrypted.data();

	// strip the leading data
	t += blksz;    // one block of random data

	// strip the file size off
	long fsize = 0;

	fsize |= (long(*t) << 24) & 0xff000000;
	t++;
	fsize |= (long(*t) << 16) & 0x00ff0000;
	t++;
	fsize |= (long(*t) <<  8) & 0x0000ff00;
	t++;
	fsize |= long(*t) & 0x000000ff;
	t++;

	if (fsize < 0 || fsize > long(encrypted.size()) - blksz - 4) {
		//kdDebug() << "fsize: " << fsize << " encrypted.size(): " << encrypted.size() << " blksz: " << blksz << endl;
		encrypted.fill(0);
		return -9;         // file structure error.
	}

when commenting out the kdDebug row I get a large number for fsize, while encrypted size looks good. blksz is 8

Just a thought. This could potentially be related/caused/be a consequence of the changes made some weeks ago for KPasswordEdit (see bug 2961)

I can reproduce the problem here. I will work on that.

This is what I get here:

kded: fsize: 4009754624
kded: fsize: 4025155584
kded: fsize: 4025179136
kded: fsize: 4025179308
kded: fsize: 4025179308 encrypted.size(): 33472 blksz: 8

from

	fsize |= (long(*t) << 24) & 0xff000000;
	kdDebug() << "fsize: " << fsize << endl;
	t++;
	fsize |= (long(*t) << 16) & 0x00ff0000;
	kdDebug() << "fsize: " << fsize << endl;
	t++;
	fsize |= (long(*t) <<  8) & 0x0000ff00;
	kdDebug() << "fsize: " << fsize << endl;
	t++;
	fsize |= long(*t) & 0x000000ff;
	kdDebug() << "fsize: " << fsize << endl;
	t++;

	if (fsize < 0 || fsize > long(encrypted.size()) - blksz - 4) {
		kdDebug() << "fsize: " << fsize << " encrypted.size(): " << encrypted.size() << " blksz: " << blksz << endl;
		encrypted.fill(0);
		return -9;         // file structure error.
	}

I hope this helps

Thank you in advance

Thanks Emanoil, I will update here as soon as I have a fix for the issue. These days are quite busy so I have just a little time for TDE each day, so I may be a bit slow 😞

Fixed by PR #14