TDE
/
tdelibs
7
1
Fork 0
Code Issues 16 Pull Requests 8 Releases Wiki Activity
Labels Milestones

tdeio: only create the internal guarded pointer for TDEIO::Job if it is really required. #192

Merged
MicheleC merged 1 commits from tdeio/improve-jobs into master 1 year ago
Conversation 0 Commits 1 Files Changed 1
MicheleC commented 1 year ago
Owner

This fix avoid creation and destruction of unnecessary TQObjects and helps speeding up operations which requires lot of Jobs.

Copying huge folders requires thousands of jobs. This PR saves quite a number of unnecessary TQObjects.

This fix avoid creation and destruction of unnecessary TQObjects and helps speeding up operations which requires lot of Jobs. Copying huge folders requires thousands of jobs. This PR saves quite a number of unnecessary TQObjects.
MicheleC added 1 commit 1 year ago
MicheleC requested review from SlavekB 1 year ago
MicheleC added this to the R14.1.0 release milestone 1 year ago
MicheleC changed title from tdeio: only create the internal guarded pointer for TDEIO::Job if it is really required. This fix avoid creation and destruction of unnecessary TQObjects and helps speeding up operations which requires lot of Jobs. to tdeio: only create the internal guarded pointer for TDEIO::Job if it is really required. 1 year ago
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

It looks good. A very good idea when the object allocation can be completely omitted.

It looks good. A very good idea when the object allocation can be completely omitted.
MicheleC merged commit ea10b6290d into master 1 year ago
MicheleC deleted branch tdeio/improve-jobs 1 year ago

Reviewers

SlavekB approved these changes 1 year ago
The pull request has been merged as ea10b6290d.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdelibs#192
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'tdeio/improve-jobs'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes