TDE
/
tdelibs
7
1
Fork 0
Code Issues 16 Pull Requests 8 Releases Wiki Activity
Labels Milestones

tdeprint: make KPrinter::setOrientation and KPrinter::setPageSize non locking by default and add ability to specify their locking behavior. #194

Merged
MicheleC merged 1 commits from tdeprint/non-locking-kprinter into master 1 year ago
Conversation 2 Commits 1 Files Changed 2
MicheleC commented 1 year ago
Owner

As per title. This PR relates to TDE/tdegraphics#54.

As per title. This PR relates to TDE/tdegraphics#54.
MicheleC added this to the R14.1.0 release milestone 1 year ago
MicheleC requested review from SlavekB 1 year ago
SlavekB commented 1 year ago
Owner

I believe that in git message it should be stated that this change maintains the compatibility of the API, but causes ABI change.

I believe that in git message it should be stated that this change maintains the compatibility of the API, but causes ABI change.
MicheleC force-pushed tdeprint/non-locking-kprinter from b5565263e9 to 8e3d9050ee 1 year ago
MicheleC commented 1 year ago
Poster
Owner

updated

updated
MicheleC force-pushed tdeprint/non-locking-kprinter from 8e3d9050ee to 9cff750d6c 1 year ago
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

Although it is quite late to change the API/ABI, it seems more appropriate to change it now than to postpone it.

Although it is quite late to change the API/ABI, it seems more appropriate to change it now than to postpone it.
👍 1
MicheleC merged commit 9cff750d6c into master 1 year ago
MicheleC deleted branch tdeprint/non-locking-kprinter 1 year ago

Reviewers

SlavekB approved these changes 1 year ago
The pull request has been merged as 9cff750d6c.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdelibs#194
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'tdeprint/non-locking-kprinter'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes