TDE
/
tdelibs
7
1
Fork 0
Code Issues 16 Pull Requests 8 Releases Wiki Activity
Labels Milestones

Fix SSL initialization for OpenSSL >= 1.1 #24

Merged
SlavekB merged 1 commits from feat/openssl-1.1-initialization into master 5 years ago
Conversation 0 Commits 1 Files Changed 1
SlavekB commented 5 years ago
Owner

The SSL library is not linked but is dynamically loaded. Older SSL library initialization functions are for OpenSSL >= 1.1 only as macros in headers – to ensure compatibility at source code level. Therefore, searching for symbols for older functions can not be successful.

The proposed patch adds detection for initialization functions for OpenSSL >= 1.1.

The SSL library is not linked but is dynamically loaded. Older SSL library initialization functions are for OpenSSL >= 1.1 only as macros in headers – to ensure compatibility at source code level. Therefore, searching for symbols for older functions can not be successful. The proposed patch adds detection for initialization functions for OpenSSL >= 1.1.
SlavekB added this to the R14.0.6 release milestone 5 years ago
MicheleC reviewed 5 years ago
tdeio/kssl/kopenssl.cc Outdated
MicheleC commented 5 years ago
Owner 
#if !defined(OPENSSL_INIT_ADD_ALL_CIPHERS)
# define OPENSSL_INIT_ADD_ALL_CIPHERS        0x00000004L
# define OPENSSL_INIT_ADD_ALL_DIGESTS        0x00000008L
# define OPENSSL_INIT_LOAD_CONFIG            0x00000040L
#endif

I think code would be more readable if these lines are moved before the function call or at the beginning of the files. They don't follow the if() block logic and in this place look a bit awkward, IMO

``` #if !defined(OPENSSL_INIT_ADD_ALL_CIPHERS) # define OPENSSL_INIT_ADD_ALL_CIPHERS 0x00000004L # define OPENSSL_INIT_ADD_ALL_DIGESTS 0x00000008L # define OPENSSL_INIT_LOAD_CONFIG 0x00000040L #endif ``` I think code would be more readable if these lines are moved before the function call or at the beginning of the files. They don't follow the if() block logic and in this place look a bit awkward, IMO
MicheleC approved these changes 5 years ago
MicheleC left a comment
Owner

Looks good now :-)

Looks good now :-)
SlavekB closed this pull request 5 years ago
SlavekB deleted branch feat/openssl-1.1-initialization 5 years ago
The pull request has been merged as 43609c8a21.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.6 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdelibs#24
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/openssl-1.1-initialization'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes