device type in tooltip not updated when mounting/unmounting a disk #35
Closed
opened 5 jaren geleden by MicheleC
·
5 comments
Laden…
Verwijs in nieuw issue
Er is nog geen inhoud.
Verwijder branch '%!s(<nil>)'
Het verwijderen van een branch is permanent. Het KAN NIET ongedaan gemaakt worden. Wil je toch doorgaan?
This can also be verified in Konqueror in system:/media.
Bug occourring in R14.0.7-DEV and R14.1.0-DEV
The mime type of the medium is correctly updatedd when mounting/unmounting a disk. The problem comes from the KDirLister not propagating the changes to the respective views (konqueror/kdesktop) for media urls.
Here the url is not recognized as local.
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/src/branch/master/tdeio/tdeio/kdirlister.cpp#L782
If adding conditions to check for media protocol items and enter the "if" block, here the search for a KFileItem fails
https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/src/branch/master/tdeio/tdeio/kdirlister.cpp#L785
It seems the correct way to fix this is to treat media:/ and system:/media urls as local and fix up the code accordingly where required (KUrl and KDirLister at least).
@SlavekB what's your view on this?
Good work! It seems that we have to find the reasons why the functions do not return the expected result. This may also fix some other problems that we haven't noticed yet.
I done some extra search. It is better not to consider a media:/ or system:/media url as local file, this could have unexpected consequences (like koffice trying to save it as a file...). Better to modify the KDirLister code to support media urls and restrict the scope and effects of the changes.
I have done further investigation. The KDirLister is treating media urls as directories and ultimately most of the info gets correctly updated. Only the mime comment is not. So it looks this comment is not correct. I will continue to investigate further.
Solved by PR #48 and TDE/tdebase#56