Fix camera device icon in hwmanager and other places. #58

Introduced by commit fee189b236 back in time.

The problem seems to have come with commit 11935291c7 and therefore only concerns the master branch.

At the same time, the question is whether file names should be camera-photo-mounted and camera-photo-umounted because camera-photo seems to be the basis used in other themes.

Interesting. Question would be, if that would interact with other places using that right name. The mediamanager, for example. So I think we can merge that now, if you are okay with it and that is open for later.

But, if I understand you right: With that change users using the classic theme for example, would have no icon as result now?

Does all this relates to bug 2675 in some ways or others?

No, but it's interesting, because after reading about that bug, I have realized that I came about that code also and I think there is a test if some device holds some DCIM folder, which be some orientation, if the phone is using a camera icon or so. I am not sure anymore exactly, but that might be related. And yes, there is also a phone icon, which could be used. But that's another topic. This here was just mainly about the "kcmhwmanager", which is only existing in the master branch. There, you have a device listing, but the camera icon here had no icon. But seems it's not that simple as I first thought. We can discuss and think about that further. 😄

I don't think this PR is required.

camera-photo is for generic camera devices and the icon name is standard and available in other icon sets too.

camera-mounted and camera-unmounted are used when accessing camera storage and they refer to different icons.

camera-photo is used when getting info for a generic camera device.

camera-mounted/unmounted when referring to storage devices in particular, which are a specialization of a generic device.

Therefore in my opinion this PR should be marked invalid.

Looked in more detail into this and discussed with Slavek.

camera-photo is in tdegraphics and tdeartwork. It is used in tdelibs inside tdehw. The correct way would be to keep the name "camera-photo" and move camera-photo from tdegraphics to tdelibs.

@Chris: ok for you to do that?

@MicheleC, sure, I can do that. I just noticed some missing icon in the hwmanager and expected that to be introduced by the pointed out series of commits back in time, because there were other places where that was really the case. But after looking on what Slavek told me and what you pointed out, that is logical. 👍

Thanks @Chris. Should I mark this PR invalid and close it and then you create new ones for moving the camera-photo icons from tdegraphics to tdelibs? Or do you prefer to use this PR and rework your commit?

@MicheleC, I will re-use this one here, but at the moment I don't have much time.

@MicheleC, I noticed that there is also filesys-camera-photo in tdegraphics. But that are the same icons. So the question is if to keep that in tdegraphics or just to move it to tdelibs too, or also just to use device-camera-photo in all that places, because filesys-camera-photo is not really needed at all? 😄

filesys-camera-photo does not seem to get install in debian. Probably safe to remove it all together??

@MicheleC, sure, how you like. 👍

If Slavek is also okay about that, I will do that. Maybe that was just something which was in planing back in time to use, but was never done.

Yes, if these icons aren't installed, then there's probably no reason to keep them here. You can possibly check if they are installed in RPM packages.

That should be okay this way.