upgrade libisofs from 0.2 to 0.4
#62
已关闭
由 Ghost 于 4 年前 打开
·
6 条评论
分支/标记未指定
r14.1.x
master
feat/kate/php-syntax-heredoc-ident
fix/tde-75
issue/270/tdelibs-V4
feat/new_hwcontrol
feat/tdeio-xattr-support
fix/api-for-python
r14.0.x
v3.5.13-sru
feat/tdehtml+svg
other/string-fixes
feat/fix-suspend-code
r14.1.2
r14.1.1
r14.1.0
r14.0.13
r14.0.12
r14.0.11
r14.0.10
r14.0.9
r14.0.8
r14.0.7
r14.0.6
r14.0.5
r14.0.4
r14.0.3
r14.0.2
r14.0.1
r14.0.0
v3.5.13.2
v3.5.13.1
v3.5.13
标签
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
添加标签
清除选中标签
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
未选择标签
GE/need-info
PR/keep-branch
PR/not-ok
PR/rfc
PR/update-trans
PR/wip
RS/R14.0.x
RS/R14.1.x
SL/critical
SL/major
SL/minor
SL/normal
SL/regression
SL/trivial
SL/wishlist
ST/duplicate
ST/invalid
ST/notourproblem
ST/rejected
ST/wontfix
ST/worksforme
里程碑
设置里程碑
取消选中里程碑
无可选项
未选择里程碑
指派成员
指派用户
取消指派成员
未指派成员
4 名参与者
通知
到期时间
到期日期无效或超出范围。请使用 'yyyy-mm-dd' 格式。
未设置到期时间。
依赖工单
没有设置依赖项。
参考:TDE/tdelibs#62
在新工单中引用
这个人很懒,什么都没留下。
删除分支 '%!s(<nil>)'
删除分支是永久的。此操作 无法 撤销,继续?
取消操作
确认操作
If I'm not mistaken, the included libisofs in tdelibs is libisfs-0.2 from 2002.
One can note that the author has released libisofs-0.4 in 2007.
First, might nice to upgrade that library, then as suggested by @SlavekB we could make a standalone libisofs library since this code has already been duplicated in k3b and krusader.
https://sourceforge.net/projects/libcdrom/files/libisofs/
To be continued...
Good point, Greg. 👍
Without looked any deeper into that, I just looked in Gentoo for that and it's still in the tree and it seems it's just maintained now by the libburnia project too.
Seems Gentoo is using that as libisofs now too.
Actually, at first, I though we could make It a shared library within tdelibs, because that code(lib) could be shared with k3b and krusader, then Slavek suggested a standalone lib.
I don't know what is the best solution here but switching to libisofs from libburnia sure is appealing.
I haven't had a look into the details but It's fair to assume that by the time a lot have changed (api) and switching tdelibs, k3b as well as krusader will require a bit of/some of/a lot of work.
The question here is whether to make efforts for existing libisofs or to leave it in its current state and pay attention to research on the possibility of using libisofs from libburnia.
As I know (Without looking deeper into that too) the libburnia developers wanted to offer their libs as drop-in replacement. At least that was the case for cdrecord. So maybe the API is still the same, more or less. But could be different, yes. Using shared libs sounds like some good option.
The same is for libparanoia. You can as far as I know use three different versions of it. Libburnia developers are keeping care of that lib too. But it seems there are quality differences. Therefore in Gentoo it is handled the way just to depend on one version to have installed of them. Maybe that would be good for TDE too. Just like done with OpenSSL and LibreSSL.
Isn't the original libisofs in the known distribution repos anymore?
I'm closing this issue because there is actually no need to upgrade libisofs-0.2 to 0.4.
The differences are aesthetics, "prettier" names for some functions (but their definitions is same code) and some pointers.
The author extracted the main function (which is not built by default) from the lib to make a standalone prog.
In short no new features, no fixes that we could care about.
Making a standalone libisofs library that links with tdelibs, k3b and krusader is an other matter.
ok, no problem.