TDE
/
tdelibs
7
1
Fork 0
Code Issues 16 Pull Requests 8 Releases Wiki Activity
Labels Milestones

Add a sub-menu "Logic Games" in Games. #75

Merged
MicheleC merged 1 commits from bug/2882/logic_game_menu into master 4 years ago
Conversation 5 Commits 1 Files Changed 1
Ghost commented 4 years ago

This relates to bug 2882.

This relates to bug 2882.
Chris commented 4 years ago
Collaborator

Great, @cethyel! 👍

I will add German translation later to the other PR's.

Great, @cethyel! :+1: I will add German translation later to the other PR's.
Ghost closed this pull request 4 years ago
MicheleC closed this pull request 4 years ago
MicheleC deleted branch bug/2882/logic_game_menu 4 years ago
MicheleC commented 4 years ago
Owner

Looks good, thanks Greg!

It seems there is some rework required in tde.

  1. The file is in tdelibs but refer to .directory files in tdebase. Not the best IMO.
  2. in the Games menu there is a KDE submenu. do we need it?
Looks good, thanks Greg!<br/> It seems there is some rework required in tde. 1. The file is in tdelibs but refer to .directory files in tdebase. Not the best IMO. 2. in the Games menu there is a KDE submenu. do we need it?
MicheleC added this to the R14.0.8 release milestone 4 years ago
Chris commented 4 years ago
Collaborator

@MicheleC: Regarding to the KDE submenu - Yes, I wanted to get ride of it too before, but after looking with Slavek, it turned out, it was needed to sort out KDE applications/games.

So every category is having some KDE submenu. Like Office -> KDE (Having the office icon too). I will mainstream that in future. Removing it will create chaos in the menu, sadly.

@MicheleC: Regarding to the KDE submenu - Yes, I wanted to get ride of it too before, but after looking with Slavek, it turned out, it was needed to sort out KDE applications/games. So every category is having some KDE submenu. Like Office -> KDE (Having the office icon too). I will mainstream that in future. Removing it will create chaos in the menu, sadly.
MicheleC commented 4 years ago
Owner

ok, thanks for explaining that. In that case we should update the KDE submenus since some categories are missing (for example in the KDE games submenu).

ok, thanks for explaining that. In that case we should update the KDE submenus since some categories are missing (for example in the KDE games submenu).
Chris commented 4 years ago
Collaborator

Yes, that KDE submenus need to be fixed. Already on my todo list. 😸

Yes, that KDE submenus need to be fixed. Already on my todo list. :smile_cat:
The pull request has been merged as d77acb6ca5.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.8 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdelibs#75
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'bug/2882/logic_game_menu'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes