TDE
/
tdelibs
7
1
Fork 0
Code Issues 16 Pull Requests 8 Releases Wiki Activity
Labels Milestones

Use private linking for exported CMake targets #88

Manually merged
SlavekB merged 1 commits from feat/use-private-linking into master 4 years ago
Conversation 0 Commits 1 Files Changed 10
SlavekB commented 4 years ago
Owner

It seems that it will be necessary to find a suitable boundary between which libraries to list as linked interfaces and which to link privately.

For example, listing ${ZLIB_LIBRARIES} as privately linked could require many modifications for other libraries and binaries that use zlib, but currently do not explicitly mention it in linked libraries because they got it thanks to tdecore-shared.

It seems that it will be necessary to find a suitable boundary between which libraries to list as linked interfaces and which to link privately. For example, listing `${ZLIB_LIBRARIES}` as privately linked could require many modifications for other libraries and binaries that use `zlib`, but currently do not explicitly mention it in linked libraries because they got it thanks to `tdecore-shared`.
SlavekB added the PR/rfc PR/wip labels 4 years ago
SlavekB changed title from WIP: Use private linking for exported CMake targets to Use private linking for exported CMake targets 4 years ago
SlavekB removed the PR/wip PR/rfc labels 4 years ago
SlavekB closed this pull request 4 years ago
SlavekB deleted branch feat/use-private-linking 4 years ago
SlavekB added this to the R14.0.9 release milestone 4 years ago
The pull request has been manually merged as 158b6e1152.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.9 release
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Depends on
#53 tde_add_library: Add the ability to link libraries as private
TDE/tde-cmake
Reference: TDE/tdelibs#88
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/use-private-linking'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes