WIP:Add an icon for bugs report. #95

Help-->Report Bug/Request Enhancement...

The mayhem with PR is that we will have the same set of icons in two differents locations, namely in:

${install_prefix}/share/icons/crystalsvg/*x*/actions/
${install_prefix}/share/apps/tdehtml/icons/crystalsvg/*x*/actions

It should be best to have only one set of icons, into the crystalsvg default folder but I'm not sure we can drop the one in tdehtml.

Any though on this will be welcomed. 😊

We shall move the bug icon to the main crystal folder if we are going to use it everywhere, IMO

The PR looks good. The question is whether to merge first and then move the bug icon into the crystal folder or instead move it first and merge then.
What is your opinion?

What is your opinion?

I'd go to merge this one first, subsequently you guys may move those icons into the crystalsvg afterwards if you feel like...

One can note that this PR will bring two missing icons in the apps menu, nontheless the solution does not work 100% since I still don't get a "bug" icon for konsole for instance.

ok then, I will merge.
For Konsole I think it must be doing something different somehow, since for example I have a "switch application language" icon even without this PR.

ups... just checking now that the bug icon would be duplicated since there are two tde_install_icons() calls for it. That doens't look right...
my bad I totally missed that before. I will think about it.

the dbg* icons are also in tdevelop, so those are also candidates to be moved to crystal I guess, since they are exactly the same files, other than the cr- or hi- prefix. Will discuss with Slavek and see the best way forward.

ups... just checking now that the bug icon would be duplicated since there are two tde_install_icons() calls for it. That doens't look right...
my bad I totally missed that before. I will think about it.

That's my first comment, same set of icons put into two different locations.

I said It several times already, the icons stuff is a total mess. 😫

If we are about to ,gradually , put every crystal icons into the "tdelibs/pics/crystalsvg" then we might as well dedicate a new module/package for this set of icons (crystal), we might even put everything into the tdeartwork module.
I wouldn't mind having all set of icons (present and future) into the tdeartwork module, might be easy to look for duplicate icons, search for icons, etc.

crystalsvg is mandatory and must be install with TDE. tdeartwork and other icons set are "at user discretion". TDE will fall back to crystal if an icon is not find in the selected icon set. So we can't move crystal to tdeartwork.

We could though create a separate crystal package if we wanted although it would be lot of work for little benefit.

Regarding moving icons to tdelibs, if an icon is used in more than one place, we should gradually go that way.

Regarding this PR, I discussed with Slavek. We will move those icons from tdehtml to crystal, then after that you can rework this PR for the changes related to the added icons.

Or the other way around: you can get rid of the change in "tdehtml/pics/CMakeLists.txt", update the PR and we can merge immediately. Then we move the icons correctly.

crystalsvg is mandatory and must be install with TDE. tdeartwork and other icons set are "at user discretion". TDE will fall back to crystal if an icon is not find in the selected icon set. So we can't move crystal to tdeartwork.

Of course we can, at the moment tdelibs and tdebase are the only mandatory modules to install, we could add tdeartwork as well.

Regarding moving icons to tdelibs, if an icon is used in more than one place, we should gradually go that way.

As you wish.

Regarding this PR, I discussed with Slavek. We will move those icons from tdehtml to crystal, then after that you can rework this PR for the changes related to the added icons.

Or the other way around: you can get rid of the change in "tdehtml/pics/CMakeLists.txt", update the PR and we can merge immediately. Then we move the icons correctly.

Please make your move, I'll adjust my PR accordingly

ok. Will try to get the move completed either tonight or tomorrow depending on th efree time I have 😄

ok. Will try to get the move completed either tonight or tomorrow depending on th efree time I have 😄

👍

Speaking of gathering icons into tdelibs, how about player_record.png from kaffeine?
That will profit to tdemultimedia and codeine.

Speaking of gathering icons into tdelibs, how about player_record.png from kaffeine?
That will profit to tdemultimedia and codeine.

One step at a time, it's on the list of thing TODO ;-)

@cethyel icons moved to tdelibs crystal. You can now update this PR and then we can merge

@cethyel icons moved to tdelibs crystal. You can now update this PR and then we can merge

My apologies, forgot to move the "bug" icon. Will do tomorrow and let you know again

...forgot to move the "bug" icon. Will do tomorrow and let you know again

I had trouble with rebasing, conflicts, etc...so don't bother, I'll move those icons in the next commit. 👍

bug icons and remaining tdehtml icons moved to crystal.

too much Pb coping with git, it's closed!

Next time you can try this:

git fetch --all --prune
git checkout master
git rebase -S
git checkout <branch name>
git rebase -S master

This will update your local repo first, then rebase your branch on top of master.

Replaced by #97.