tderandr: hardcoded rotation strings don't allow localization #96

已关闭
jstolarek4 年前创建 · 12 条评论
jstolarek 评论于 4 年前
协作者

libtderandr.h hardcodes strings used to describe rotation:

#define ROTATION_0_DEGREES_STRING "0 degrees"
#define ROTATION_90_DEGREES_STRING "90 degrees"
#define ROTATION_180_DEGREES_STRING "180 degrees"
#define ROTATION_270_DEGREES_STRING "270 degrees"

and IIUC there is no way to localize these strings so they always show up in English. An example where they appear is the TCC Monitor & Display module -> Resolution and Layout tab -> "Rotate screen by:" combo box

[libtderandr.h](https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/src/branch/master/tderandr/libtderandr.h#L38) hardcodes strings used to describe rotation: ``` #define ROTATION_0_DEGREES_STRING "0 degrees" #define ROTATION_90_DEGREES_STRING "90 degrees" #define ROTATION_180_DEGREES_STRING "180 degrees" #define ROTATION_270_DEGREES_STRING "270 degrees" ``` and IIUC there is no way to localize these strings so they always show up in English. An example where they appear is the TCC Monitor & Display module -> Resolution and Layout tab -> "Rotate screen by:" combo box
jstolarek4 年前 添加了标签 SL/normal
SlavekB 评论于 4 年前
所有者

The strings for rotations in tderandr will be extracted for translation during the regular update of POT files – ie on Sunday evening.

Thank you for your warning about this shortcoming!

The strings for rotations in tderandr will be extracted for translation during the regular update of POT files – ie on Sunday evening. Thank you for your warning about this shortcoming!
jstolarek 评论于 4 年前
发布者
协作者

Great. Will these be available via Weblate? If so, where?

Great. Will these be available via Weblate? If so, where?
SlavekB 评论于 4 年前
所有者

Once the strings are extracted into the POT file, they will be available on TWTW.

Now Michele has found that more work is needed there, because now there could be situations where translated × untranslated strings are compared in the code => it would not work. So there will be the necessary adjustments in the code. This made the task more difficult than I expected.

Once the strings are extracted into the POT file, they will be available on TWTW. Now Michele has found that more work is needed there, because now there could be situations where translated × untranslated strings are compared in the code => it would not work. So there will be the necessary adjustments in the code. This made the task more difficult than I expected.
MicheleC 评论于 4 年前
所有者

PRs ready for testing and feedback. If approved, then we need to wait for the strings to be extracted in the .pot file and later translated using TWTW.

PRs ready for testing and feedback. If approved, then we need to wait for the strings to be extracted in the .pot file and later translated using TWTW.
MicheleC 评论于 4 年前
所有者

PRs have been merged. We should now wait for the packages to be rebuilt, the strings to become avaiable for translation on TWTW and later make sure the translations work.

PRs have been merged. We should now wait for the packages to be rebuilt, the strings to become avaiable for translation on TWTW and later make sure the translations work.
SlavekB4 年前 添加了里程碑 R14.0.9 release
SlavekB 评论于 4 年前
所有者

If you have TWTW notification enabled for new strings to translate, then you already know that strings are already available for translation.

If you have TWTW notification enabled for new strings to translate, then you already know that strings are already available for translation.
MicheleC 评论于 4 年前
所有者

Great, strings already in TWTW for translation. Waiting for the merge into tde-i18n for later testing.

Great, strings already in TWTW for translation. Waiting for the merge into tde-i18n for later testing.
jstolarek 评论于 4 年前
发布者
协作者

If you have TWTW notification enabled for new strings to translate

Didn't know there's such a feature. How do I enable it?

> If you have TWTW notification enabled for new strings to translate Didn't know there's such a feature. How do I enable it?
SlavekB 评论于 4 年前
所有者

If you have TWTW notification enabled for new strings to translate

Didn't know there's such a feature. How do I enable it?

In the settings of your profile in TWTW you can select the projects you want to monitor and the events for which you want to receive notifications.

> > If you have TWTW notification enabled for new strings to translate > > Didn't know there's such a feature. How do I enable it? > In the settings of your profile in TWTW you can select the projects you want to monitor and the events for which you want to receive notifications.
MicheleC 评论于 4 年前
所有者

Translation compiled and working properly!

Translation compiled and working properly!
MicheleC4 年前 关闭此工单
MicheleC 评论于 4 年前
所有者

@jstolarek please just double check on R14.0.x when the official packages are ready. I build and tested locally with Italian on R14.1.0, but I expect no issues with R14.0.x. Just to be sure.

@jstolarek please just double check on R14.0.x when the official packages are ready. I build and tested locally with Italian on R14.1.0, but I expect no issues with R14.0.x. Just to be sure.
jstolarek 评论于 4 年前
发布者
协作者

Everything works as expected. I just pulled translated packages from the repo and degree strings show translated.

Everything works as expected. I just pulled translated packages from the repo and degree strings show translated.
登录 并参与到对话中。
未选择里程碑
未指派成员
3 名参与者
通知
到期时间

未设置到期时间。

依赖工单

没有设置依赖项。

参考:TDE/tdelibs#96
正在加载...
这个人很懒,什么都没留下。