TDE
/
tdelibs
7
1
Fork 0
Code Issues 16 Pull Requests 8 Releases Wiki Activity
Labels Milestones

Allow to use backtrace(3) external library for kdebug #103

Merged
MicheleC merged 2 commits from feat/add-libexecinfo-support into master 4 years ago
Conversation 5 Commits 2 Files Changed 4
obache commented 4 years ago
Collaborator

tested with BSD licence libexecinfo

tested with BSD licence libexecinfo
MicheleC approved these changes 4 years ago
MicheleC left a comment
Owner

Looks good to me!

Looks good to me!
MicheleC reviewed 4 years ago
config.h.cmake Outdated
#cmakedefine HAVE_STRVERCMP_PROTO 1
/* Define to 1 if execinfo.h exists and defines backtrace (GLIBC >= 2.1) */
/* Define to 1 if backtrace information library */
MicheleC commented 4 years ago
Owner

Could you add "exists" to the comment?

/* Define to 1 if backtrace information library exists */
Could you add "exists" to the comment? ``` /* Define to 1 if backtrace information library exists */ ```
obache commented 4 years ago
Poster
Collaborator

It should be "... if you have backtrace ...", as my local patch... :-(

It should be "... if you have backtrace ...", as my local patch... :-(
MicheleC reviewed 4 years ago
CMakeLists.txt Outdated
set ( Backtrace_HEADER "execinfo.h" )
endif ()
else ()
find_package( Backtrace )
MicheleC commented 4 years ago
Owner

Maybe I am asking a stupid question, forgive my ignorance. Why are we using "Backtrace" with capital 'B'?

Maybe I am asking a stupid question, forgive my ignorance. Why are we using "Backtrace" with capital 'B'?
SlavekB commented 4 years ago
Owner

I assume that capital 'B' is because the file itself is called FindBacktrace.cmake.

I assume that capital 'B' is because the file itself is called `FindBacktrace.cmake`.
obache commented 4 years ago
Poster
Collaborator

Yes, from the spec of find_package(), find_package( Backtrace ) will find FindBacktrace.cmake or backtrace-config.cmake.

Yes, from the spec of find_package(), find_package( Backtrace ) will find `FindBacktrace.cmake` or `backtrace-config.cmake`.
MicheleC commented 4 years ago
Owner

ok, thanks for the explanation Obata-san.

ok, thanks for the explanation Obata-san.
SlavekB commented 4 years ago
Owner

Test on FreeBSD:

-- Looking for backtrace
-- Looking for backtrace - not found
-- Found Backtrace: /usr/lib/libexecinfo.so
-- Performing Test HAVE_ABI_CXA_DEMANGLE
-- Performing Test HAVE_ABI_CXA_DEMANGLE - Success

ld: error: undefined symbol: backtrace
>>> referenced by kdebug.cpp:813 (../tdecore/kdebug.cpp:813)
>>>               tdecore/CMakeFiles/tdecore-shared.dir/kdebug.cpp.o:(kdBacktrace(int))

ld: error: undefined symbol: backtrace
>>> referenced by kdebug.cpp:843 (../tdecore/kdebug.cpp:843)
>>>               tdecore/CMakeFiles/tdecore-shared.dir/kdebug.cpp.o:(kdBacktraceFD(int))

ld: error: undefined symbol: backtrace_symbols_fd
>>> referenced by kdebug.cpp:845 (../tdecore/kdebug.cpp:845)
>>>               tdecore/CMakeFiles/tdecore-shared.dir/kdebug.cpp.o:(kdBacktraceFD(int))
c++: error: linker command failed with exit code 1 (use -v to see invocation)
Test on FreeBSD: ``` -- Looking for backtrace -- Looking for backtrace - not found -- Found Backtrace: /usr/lib/libexecinfo.so -- Performing Test HAVE_ABI_CXA_DEMANGLE -- Performing Test HAVE_ABI_CXA_DEMANGLE - Success ``` ``` ld: error: undefined symbol: backtrace >>> referenced by kdebug.cpp:813 (../tdecore/kdebug.cpp:813) >>> tdecore/CMakeFiles/tdecore-shared.dir/kdebug.cpp.o:(kdBacktrace(int)) ld: error: undefined symbol: backtrace >>> referenced by kdebug.cpp:843 (../tdecore/kdebug.cpp:843) >>> tdecore/CMakeFiles/tdecore-shared.dir/kdebug.cpp.o:(kdBacktraceFD(int)) ld: error: undefined symbol: backtrace_symbols_fd >>> referenced by kdebug.cpp:845 (../tdecore/kdebug.cpp:845) >>> tdecore/CMakeFiles/tdecore-shared.dir/kdebug.cpp.o:(kdBacktraceFD(int)) c++: error: linker command failed with exit code 1 (use -v to see invocation) ```
SlavekB requested changes 4 years ago
SlavekB left a comment
Owner

The test on Wheezy (CMake 2.8.x) and Stretch (CMake 3.7.x) is fine, but the test on FreeBSD ends with FTBFS. See comment above.

The test on Wheezy (CMake 2.8.x) and Stretch (CMake 3.7.x) is fine, but the test on FreeBSD ends with FTBFS. See comment above.
SlavekB commented 4 years ago
Owner

FTBFS on FreeBSD (with external library for backtrace) resolved in commit 59debdf4f0.

FTBFS on FreeBSD (with external library for backtrace) resolved in commit 59debdf4f0.
SlavekB requested review from MicheleC 4 years ago
SlavekB approved these changes 4 years ago
SlavekB left a comment
Owner

Successfully tested on DEB distributions and on FreeBSD.

Successfully tested on DEB distributions and on FreeBSD.
MicheleC approved these changes 4 years ago
MicheleC left a comment
Owner

Looks good to me 👍

Looks good to me :+1:
MicheleC merged commit 59debdf4f0 into master 4 years ago
MicheleC deleted branch feat/add-libexecinfo-support 4 years ago
MicheleC added this to the R14.0.9 release milestone 4 years ago
MicheleC commented 4 years ago
Owner

Thanks Obata for the PR and Slavek for testing and fixing in FreeBSD.

Thanks Obata for the PR and Slavek for testing and fixing in FreeBSD.
obache commented 4 years ago
Poster
Collaborator

Sorry, I missed to add the diff for CMakeLists.txt in this PR.
It is because I don't have master branch test environment, just backported to master from patchset for release taball manually.

Sorry, I missed to add the diff for CMakeLists.txt in this PR. It is because I don't have master branch test environment, just backported to master from patchset for release taball manually.
MicheleC commented 4 years ago
Owner

Sorry, I missed to add the diff for CMakeLists.txt in this PR.
It is because I don't have master branch test environment, just backported to master from patchset for release taball manually.

No worries Obata-san, keep up the excellent work you are doing 😄 It is very much appreciated.

> Sorry, I missed to add the diff for CMakeLists.txt in this PR. > It is because I don't have master branch test environment, just backported to master from patchset for release taball manually. No worries Obata-san, keep up the excellent work you are doing :smile: It is very much appreciated.

Reviewers

SlavekB approved these changes 4 years ago
MicheleC approved these changes 4 years ago
The pull request has been merged as 59debdf4f0.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
MicheleC
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.9 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdelibs#103
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/add-libexecinfo-support'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes