TDE
/
tdelibs
7
1
Fork 0
Código Incidencias 16 Pull Requests 8 Lanzamientos Wiki Actividad
Etiquetas Hitos

Fix to access old TDE wallet with special characters (R14.0.x series) #16

Fusionado
MicheleC fusionados 1 commits de feat/tdewallet-access-R14-0-6 en r14.0.x hace 5 años
Conversación 2 Commits 1 Archivos modificados 1
MicheleC comentado hace 5 años
Propietario

Same as #15 but for R14.0.x series

Same as #15 but for R14.0.x series
MicheleC ha añadido esto al hito R14.0.6 release hace 5 años
SlavekB comentado hace 5 años
Propietario

Problem with previous patch version identified and resolved. This was a similar problem as we recently dealt with in KPasswordEdit::password().

Calling TQString::fromLocal8Bit( "..." ) creates a temporary TQString object, but the subsequent use of const char * obtained by the ascii() method then refers to a portion of memory that has already been released and used for another purpose.

With a modified version of the patch, opening a wallet with a password with special characters works also in R14.0.6.

Problem with previous patch version identified and resolved. This was a similar problem as we recently dealt with in `KPasswordEdit::password()`. Calling `TQString::fromLocal8Bit( "..." )` creates a temporary TQString object, but the subsequent use of `const char *` obtained by the `ascii()` method then refers to a portion of memory that has already been released and used for another purpose. With a modified version of the patch, opening a wallet with a password with special characters works also in R14.0.6.
MicheleC comentado hace 5 años
Autor
Propietario

Great! I think we are ready to merge then

Great! I think we are ready to merge then
MicheleC cerró este pull request hace 5 años
MicheleC rama eliminada feat/tdewallet-access-R14-0-6 hace 5 años
El Pull Request se ha fusionado como 987768c54d.
Inicie sesión para unirse a esta conversación.
Revisores
Solicitar revisión
No hay revisores
Etiquetas
Aplicar etiquetas
Limpiar etiquetas
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Sin etiquetas GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Fijar hito
Limpiar Milestone
No hay elementos
Sin Milestone
R14.0.6 release
Asignados
Asignar usuarios
Limpiar asignados
No asignados
2 participantes
Notificaciones
Fecha de vencimiento

Sin fecha de vencimiento.

Dependencias

No se han establecido dependencias.

Referencia: TDE/tdelibs#16
Escribir Vista previa
Cargando…
Cancelar
Guardar
Aún no existe contenido.
Eliminar la rama con el nombre 'feat/tdewallet-access-R14-0-6'

Eliminar una rama es permanente. NO PUEDE deshacerse. ¿Continuar?

No
Sí