TDE
/
tdelibs
7
1
Forka 0
Codice Problemi 16 Pull Requests 8 Rilasci Wiki Attività
Etichette Traguardi

Fix to access old TDE wallet with special characters (R14.0.x series) #16

Unito
MicheleC ha unito 1 commit da feat/tdewallet-access-R14-0-6 a r14.0.x 5 anni fa
Conversazione 2 Commit 1 File modificati 1
MicheleC 5 anni fa ha commentato
Proprietario

Same as #15 but for R14.0.x series

Same as #15 but for R14.0.x series
MicheleC aggiunta alle pietre miliari R14.0.6 release 5 anni fa
SlavekB 5 anni fa ha commentato
Proprietario

Problem with previous patch version identified and resolved. This was a similar problem as we recently dealt with in KPasswordEdit::password().

Calling TQString::fromLocal8Bit( "..." ) creates a temporary TQString object, but the subsequent use of const char * obtained by the ascii() method then refers to a portion of memory that has already been released and used for another purpose.

With a modified version of the patch, opening a wallet with a password with special characters works also in R14.0.6.

Problem with previous patch version identified and resolved. This was a similar problem as we recently dealt with in `KPasswordEdit::password()`. Calling `TQString::fromLocal8Bit( "..." )` creates a temporary TQString object, but the subsequent use of `const char *` obtained by the `ascii()` method then refers to a portion of memory that has already been released and used for another purpose. With a modified version of the patch, opening a wallet with a password with special characters works also in R14.0.6.
MicheleC 5 anni fa ha commentato
Autore
Proprietario

Great! I think we are ready to merge then

Great! I think we are ready to merge then
MicheleC chiusa questa pull request 5 anni fa
MicheleC branch feat/tdewallet-access-R14-0-6 eliminato 5 anni fa
La pull request è stata unita come 987768c54d.
Effettua l'accesso per partecipare alla conversazione.
Revisori
Richiedi revisione
Nessun revisore
Etichette
Applica etichette
Pulisci le etichette
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Nessuna etichetta GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Traguardo
Imposta traguardo
Milestone pulita
Nessun elemento
Nessuna milestone
R14.0.6 release
Assegnatari
Assegna utenti
Cancella assegnatari
Nessuna assegnatario
2 Partecipanti
Notifiche
Data di scadenza

Nessuna data di scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Riferimento: TDE/tdelibs#16
Scrivi Anteprima
Caricamento…
Annulla
Salva
Non ci sono ancora contenuti.
Elimina branch 'feat/tdewallet-access-R14-0-6'

L'eliminazione di un branch è definitiva. È un'operazione che NON PUÒ essere annullata. Continuare?

No
Sì