TDE
/
tdelibs
7
1
Vork 0
Code Kwesties 16 Pull-aanvragen 8 Publicaties Wiki Activiteit
Labels Mijlpalen

Fix to access old TDE wallet with special characters (R14.0.x series) #16

Samengevoegd
MicheleC heeft 1 commits samengevoegd van feat/tdewallet-access-R14-0-6 naar r14.0.x 5 jaren geleden
Discussie 2 Commits 1 Bestanden gewijzigd 1
MicheleC commented 5 jaren geleden
Eigenaar

Same as #15 but for R14.0.x series

Same as #15 but for R14.0.x series
MicheleC heeft dit 5 jaren geleden aan de mijlpaal R14.0.6 release toegevoegd
SlavekB commented 5 jaren geleden
Eigenaar

Problem with previous patch version identified and resolved. This was a similar problem as we recently dealt with in KPasswordEdit::password().

Calling TQString::fromLocal8Bit( "..." ) creates a temporary TQString object, but the subsequent use of const char * obtained by the ascii() method then refers to a portion of memory that has already been released and used for another purpose.

With a modified version of the patch, opening a wallet with a password with special characters works also in R14.0.6.

Problem with previous patch version identified and resolved. This was a similar problem as we recently dealt with in `KPasswordEdit::password()`. Calling `TQString::fromLocal8Bit( "..." )` creates a temporary TQString object, but the subsequent use of `const char *` obtained by the `ascii()` method then refers to a portion of memory that has already been released and used for another purpose. With a modified version of the patch, opening a wallet with a password with special characters works also in R14.0.6.
MicheleC commented 5 jaren geleden
Poster
Eigenaar

Great! I think we are ready to merge then

Great! I think we are ready to merge then
MicheleC heeft deze pull request gesloten 5 jaren geleden
MicheleC heeft 5 jaren geleden de branch feat/tdewallet-access-R14-0-6 verwijderd.
De pull request is samengevoegd als 987768c54d.
Log in om deel te nemen aan deze discussie.
Reviewers
Beoordeling aanvragen
Geen beoordelaars
Labels
Labels toepassen
Verwijder labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Geen label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Mijlpaal
Stel mijlpaal in
Verwijder mijlpaal
Geen items
Geen mijlpaal
R14.0.6 release
Toegewezen aan
Gebruikers toewijzen
Verwijder toegewezen aan
Niet toegewezen
2 deelnemers
Notificaties
Vervaldatum

Geen vervaldatum ingesteld.

Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: TDE/tdelibs#16
Schrijf Voorbeeld
Laden…
Annuleren
Opslaan
Er is nog geen inhoud.
Verwijder branch 'feat/tdewallet-access-R14-0-6'

Het verwijderen van een branch is permanent. Het KAN NIET ongedaan gemaakt worden. Wil je toch doorgaan?

Nee
Ja