TDE
/
tdelibs
7
1
Fork 0
Código Issues 16 Pull requests 9 Versões Wiki Atividade
Etiquetas Marcos

Fix to access old TDE wallet with special characters (R14.0.x series) #16

Merge aplicado
MicheleC aplicou merge dos 1 commits de feat/tdewallet-access-R14-0-6 em r14.0.x 5 anos atrás
Conversação 2 Commits 1 Arquivos alterados 1
MicheleC comentou 5 anos atrás
Proprietário

Same as #15 but for R14.0.x series

Same as #15 but for R14.0.x series
MicheleC adicionou esta issue para o marco R14.0.6 release 5 anos atrás
SlavekB comentou 5 anos atrás
Proprietário

Problem with previous patch version identified and resolved. This was a similar problem as we recently dealt with in KPasswordEdit::password().

Calling TQString::fromLocal8Bit( "..." ) creates a temporary TQString object, but the subsequent use of const char * obtained by the ascii() method then refers to a portion of memory that has already been released and used for another purpose.

With a modified version of the patch, opening a wallet with a password with special characters works also in R14.0.6.

Problem with previous patch version identified and resolved. This was a similar problem as we recently dealt with in `KPasswordEdit::password()`. Calling `TQString::fromLocal8Bit( "..." )` creates a temporary TQString object, but the subsequent use of `const char *` obtained by the `ascii()` method then refers to a portion of memory that has already been released and used for another purpose. With a modified version of the patch, opening a wallet with a password with special characters works also in R14.0.6.
MicheleC comentou 5 anos atrás
Autor
Proprietário

Great! I think we are ready to merge then

Great! I think we are ready to merge then
MicheleC fechou este pull request 5 anos atrás
MicheleC excluiu branch feat/tdewallet-access-R14-0-6 5 anos atrás
O pull request teve merge aplicado como 987768c54d.
Acesse para participar desta conversação.
Revisores
Solicitar revisão
Sem revisor
Etiquetas
Aplicar etiquetas
Limpar etiquetas
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Sem etiqueta GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Marco
Definir marco
Limpar marco
Nenhum item
Sem marco
R14.0.6 release
Responsáveis
Atribuir usuários
Limpar responsáveis
Sem responsável
2 participante(s)
Notificações
Data limite

Data limite não informada.

Dependências

Nenhuma dependência definida.

Referência: TDE/tdelibs#16
Escrever Pré-visualização
Carregando…
Cancelar
Salvar
Ainda não há conteúdo.
Excluir Branch 'feat/tdewallet-access-R14-0-6'

A exclusão de um branch é permanente. Isto NÃO PODERÁ ser desfeito. Continuar?

Não
Sim