標籤 里程碑

Fix to access old TDE wallet with special characters (R14.0.x series) #16

已合併

MicheleC 於 5 年之前 將 1 次代碼提交從 feat/tdewallet-access-R14-0-6 合併至 r14.0.x

對話內容 2 程式碼提交 1 Files Changed 1

MicheleC 評論 5 年之前

所有者

Same as #15 but for R14.0.x series

Same as #15 but for R14.0.x series

MicheleC 新增至R14.0.6 release 里程碑 5 年之前

SlavekB 評論 5 年之前

所有者

Problem with previous patch version identified and resolved. This was a similar problem as we recently dealt with in KPasswordEdit::password().

Calling TQString::fromLocal8Bit( "..." ) creates a temporary TQString object, but the subsequent use of const char * obtained by the ascii() method then refers to a portion of memory that has already been released and used for another purpose.

With a modified version of the patch, opening a wallet with a password with special characters works also in R14.0.6.

Problem with previous patch version identified and resolved. This was a similar problem as we recently dealt with in `KPasswordEdit::password()`. Calling `TQString::fromLocal8Bit( "..." )` creates a temporary TQString object, but the subsequent use of `const char *` obtained by the `ascii()` method then refers to a portion of memory that has already been released and used for another purpose. With a modified version of the patch, opening a wallet with a password with special characters works also in R14.0.6.

MicheleC 評論 5 年之前

發佈者

所有者

Great! I think we are ready to merge then

Great! I think we are ready to merge then

MicheleC closed this pull request 5 年之前

MicheleC 刪除分支 feat/tdewallet-access-R14-0-6 5 年之前

The pull request has been merged as 987768c54d.

登入 才能加入這對話。

Reviewers

Request review

No reviewers

標籤

Apply labels

清除已選取標籤

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

未選擇標籤 GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

里程碑

Set milestone

清除已選取里程碑

No items

未選擇里程碑

R14.0.6 release

Assignees

Assign users

Clear assignees

No Assignees

2 參與者

訊息

訂閱

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdelibs#16

Write Preview

Loading…

取消

儲存

尚未有任何內容