Fix if-else syntax for the case missing OSS support #22
Zusammengeführt
SlavekB
hat 1 Commits von feat/fix-if-else-cond
nach master
vor 5 Jahren zusammengeführt
Laden…
In neuem Issue referenzieren
Hier gibt es bis jetzt noch keinen Inhalt.
Branch „feat/fix-if-else-cond“ löschen
Das Löschen eines Branches ist permanent. Es KANN NICHT rückgängig gemacht werden. Fortfahren?
OSS MIDI API may be missing even if ALSA is enabled.
Please consider simplifying the code as suggested in the comment.
#endif
#ifdef HAVE_OSS_SUPPORT
_seqbufptr=0;
#endif
The combination of nested #ifdef and if-else in the code looks hard to read. I propose simplification as follows:
a simpler version is:
Yes, of course, this can make the code even simpler. I chose the closed block also for OSS to make it clear if there will be added support for some other sound systems – for example, for Solaris 😸
For multiple sound systems support, is it intend to be runtime switching or build time?
For multiple sound systems support, is it intend to be runtime switching or build time?
Please give attention to my review – see comment above.
Changed to coding style same as others.
dd6da7345a
gemergt.