Fix if-else syntax for the case missing OSS support #22

병합

SlavekB feat/fix-if-else-cond 에서 master 로 1 commits 를 머지했습니다

obache 코멘트됨,

협업자

OSS MIDI API may be missing even if ALSA is enabled.

SlavekB 검토됨

SlavekB left a comment

소유자

Please consider simplifying the code as suggested in the comment.

libtdemid/deviceman.cc

													
					#endif

					#ifdef HAVE_OSS_SUPPORT

					    _seqbufptr=0;

					#endif

SlavekB 코멘트됨,

소유자

The combination of nested #ifdef and if-else in the code looks hard to read. I propose simplification as follows:

#ifdef HAVE_ALSA_SUPPORT
  if (alsa)
  {
    ((AlsaOut *)device[default_dev])->seqbuf_clean();
    return;
  }
#endif
#ifdef HAVE_OSS_SUPPORT
  {
    _seqbufptr=0;
   return;
  }
#endif

MicheleC 코멘트됨,

소유자

a simpler version is:

#ifdef HAVE_ALSA_SUPPORT
  if (alsa)
  {
    ((AlsaOut *)device[default_dev])->seqbuf_clean();
    return;
  }
#endif
#ifdef HAVE_OSS_SUPPORT
  _seqbufptr=0;
#endif

SlavekB 코멘트됨,

소유자

Yes, of course, this can make the code even simpler. I chose the closed block also for OSS to make it clear if there will be added support for some other sound systems – for example, for Solaris 😸

obache 코멘트됨,

포스터

협업자

For multiple sound systems support, is it intend to be runtime switching or build time?

obache 코멘트됨,

포스터

협업자

For multiple sound systems support, is it intend to be runtime switching or build time?

SlavekB 코멘트됨,

소유자

Please give attention to my review – see comment above.

obache 코멘트됨,

포스터

협업자

Changed to coding style same as others.

SlavekB closed this pull request

SlavekB 삭제된 브랜치 feat/fix-if-else-cond

SlavekB R14.0.6 release 마일스톤을 추가하였습니다.

The pull request has been merged as dd6da7345a.

로그인하여 이 대화에 참여

No reviewers

담당자 없음

참여자 3명

알림

마감일

마감일이 설정되지 않았습니다.

의존성

No dependencies set.

Reference: TDE/tdelibs#22