Fix if-else syntax for the case missing OSS support #22

已合併

SlavekB 於將 1 次代碼提交從 feat/fix-if-else-cond 合併至 master

obache 評論

協同者

OSS MIDI API may be missing even if ALSA is enabled.

SlavekB reviewed

SlavekB left a comment

所有者

Please consider simplifying the code as suggested in the comment.

libtdemid/deviceman.cc

													
					#endif

					#ifdef HAVE_OSS_SUPPORT

					    _seqbufptr=0;

					#endif

SlavekB 評論

所有者

The combination of nested #ifdef and if-else in the code looks hard to read. I propose simplification as follows:

#ifdef HAVE_ALSA_SUPPORT
  if (alsa)
  {
    ((AlsaOut *)device[default_dev])->seqbuf_clean();
    return;
  }
#endif
#ifdef HAVE_OSS_SUPPORT
  {
    _seqbufptr=0;
   return;
  }
#endif

MicheleC 評論

所有者

a simpler version is:

#ifdef HAVE_ALSA_SUPPORT
  if (alsa)
  {
    ((AlsaOut *)device[default_dev])->seqbuf_clean();
    return;
  }
#endif
#ifdef HAVE_OSS_SUPPORT
  _seqbufptr=0;
#endif

SlavekB 評論

所有者

Yes, of course, this can make the code even simpler. I chose the closed block also for OSS to make it clear if there will be added support for some other sound systems – for example, for Solaris 😸

obache 評論

發佈者

協同者

For multiple sound systems support, is it intend to be runtime switching or build time?

obache 評論

發佈者

協同者

For multiple sound systems support, is it intend to be runtime switching or build time?

SlavekB 評論

所有者

Please give attention to my review – see comment above.

obache 評論

發佈者

協同者

Changed to coding style same as others.

SlavekB closed this pull request

SlavekB 刪除分支 feat/fix-if-else-cond

SlavekB 新增至R14.0.6 release 里程碑

The pull request has been merged as dd6da7345a.

登入才能加入這對話。

No reviewers

No Assignees

3 參與者

訊息

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdelibs#22