Fix if-else syntax for the case missing OSS support #22
已合併
SlavekB
將 1 次提交從 feat/fix-if-else-cond
合併至 master
5 年前
載入中…
新增問題並參考
尚未有任何內容
刪除分支「feat/fix-if-else-cond」
刪除分支是永久的。 此動作不可還原,是否繼續?
OSS MIDI API may be missing even if ALSA is enabled.
Please consider simplifying the code as suggested in the comment.
#endif
#ifdef HAVE_OSS_SUPPORT
_seqbufptr=0;
#endif
The combination of nested #ifdef and if-else in the code looks hard to read. I propose simplification as follows:
a simpler version is:
Yes, of course, this can make the code even simpler. I chose the closed block also for OSS to make it clear if there will be added support for some other sound systems – for example, for Solaris 😸
For multiple sound systems support, is it intend to be runtime switching or build time?
For multiple sound systems support, is it intend to be runtime switching or build time?
Please give attention to my review – see comment above.
Changed to coding style same as others.
dd6da7345a
。