TDE
/
tdelibs
7
1
Разклонения 0
Код Задачи 16 Заявки за сливане 8 Версии Уики Activity
Етикети Етапи

Fix SSL initialization for OpenSSL >= 1.1 #24

Обединени
SlavekB обедини 1 ревизии от feat/openssl-1.1-initialization във master преди 5 години
Разговор 0 Ревизии 1 Променени файлове 1
SlavekB коментира преди 5 години
Притежател

The SSL library is not linked but is dynamically loaded. Older SSL library initialization functions are for OpenSSL >= 1.1 only as macros in headers – to ensure compatibility at source code level. Therefore, searching for symbols for older functions can not be successful.

The proposed patch adds detection for initialization functions for OpenSSL >= 1.1.

The SSL library is not linked but is dynamically loaded. Older SSL library initialization functions are for OpenSSL >= 1.1 only as macros in headers – to ensure compatibility at source code level. Therefore, searching for symbols for older functions can not be successful. The proposed patch adds detection for initialization functions for OpenSSL >= 1.1.
SlavekB added this to the R14.0.6 release milestone преди 5 години
MicheleC reviewed преди 5 години
tdeio/kssl/kopenssl.cc Outdated
MicheleC коментира преди 5 години
Притежател 
#if !defined(OPENSSL_INIT_ADD_ALL_CIPHERS)
# define OPENSSL_INIT_ADD_ALL_CIPHERS        0x00000004L
# define OPENSSL_INIT_ADD_ALL_DIGESTS        0x00000008L
# define OPENSSL_INIT_LOAD_CONFIG            0x00000040L
#endif

I think code would be more readable if these lines are moved before the function call or at the beginning of the files. They don't follow the if() block logic and in this place look a bit awkward, IMO

``` #if !defined(OPENSSL_INIT_ADD_ALL_CIPHERS) # define OPENSSL_INIT_ADD_ALL_CIPHERS 0x00000004L # define OPENSSL_INIT_ADD_ALL_DIGESTS 0x00000008L # define OPENSSL_INIT_LOAD_CONFIG 0x00000040L #endif ``` I think code would be more readable if these lines are moved before the function call or at the beginning of the files. They don't follow the if() block logic and in this place look a bit awkward, IMO
MicheleC approved these changes преди 5 години
MicheleC left a comment
Притежател

Looks good now :-)

Looks good now :-)
SlavekB closed this pull request преди 5 години
SlavekB deleted branch feat/openssl-1.1-initialization преди 5 години
Тази заявка за сливане е била обединена като 43609c8a21.
Впишете се за да се присъедините към разговора.
Reviewers
Request review
No reviewers
Етикети
Apply labels
Изчисти етикети
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Няма етикет GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Етап
Set milestone
Изчисти етап
No items
Няма етап
R14.0.6 release
Изпълнители
Assign users
Изчисти изпълнители
Няма изпълнители
2 участника
Известия
Due Date

No due date set.

Зависимости

No dependencies set.

Reference: TDE/tdelibs#24
Пиши Преглед
Зареждане…
Отказ
Запис
Все още няма съдържание.
Delete Branch 'feat/openssl-1.1-initialization'

Deleting a branch is permanent. It CANNOT be undone. Continue?

Не
Да