TDE
/
tdelibs
7
1
Bifurcation 0
Code Tickets 16 Demandes d'ajout 8 Versions Wiki Activité
Étiquettes Jalons

Fix SSL initialization for OpenSSL >= 1.1 #24

Fusionnée
SlavekB a fusionné 1 révision(s) à partir de feat/openssl-1.1-initialization vers master il y a 5 ans
Discussion 0 Révisions 1 Fichiers Modifiés 1
SlavekB a commenté il y a 5 ans
Propriétaire

The SSL library is not linked but is dynamically loaded. Older SSL library initialization functions are for OpenSSL >= 1.1 only as macros in headers – to ensure compatibility at source code level. Therefore, searching for symbols for older functions can not be successful.

The proposed patch adds detection for initialization functions for OpenSSL >= 1.1.

The SSL library is not linked but is dynamically loaded. Older SSL library initialization functions are for OpenSSL >= 1.1 only as macros in headers – to ensure compatibility at source code level. Therefore, searching for symbols for older functions can not be successful. The proposed patch adds detection for initialization functions for OpenSSL >= 1.1.
SlavekB a ajouté cela au jalon R14.0.6 release il y a 5 ans
MicheleC révisé il y a 5 ans
tdeio/kssl/kopenssl.cc Périmé
MicheleC a commenté il y a 5 ans
Propriétaire 
#if !defined(OPENSSL_INIT_ADD_ALL_CIPHERS)
# define OPENSSL_INIT_ADD_ALL_CIPHERS        0x00000004L
# define OPENSSL_INIT_ADD_ALL_DIGESTS        0x00000008L
# define OPENSSL_INIT_LOAD_CONFIG            0x00000040L
#endif

I think code would be more readable if these lines are moved before the function call or at the beginning of the files. They don't follow the if() block logic and in this place look a bit awkward, IMO

``` #if !defined(OPENSSL_INIT_ADD_ALL_CIPHERS) # define OPENSSL_INIT_ADD_ALL_CIPHERS 0x00000004L # define OPENSSL_INIT_ADD_ALL_DIGESTS 0x00000008L # define OPENSSL_INIT_LOAD_CONFIG 0x00000040L #endif ``` I think code would be more readable if these lines are moved before the function call or at the beginning of the files. They don't follow the if() block logic and in this place look a bit awkward, IMO
MicheleC ces changements ont été approuvés il y a 5 ans
MicheleC laisser un commentaire
Propriétaire

Looks good now :-)

Looks good now :-)
SlavekB a fermé cette pull request il y a 5 ans
SlavekB a supprimé la branche feat/openssl-1.1-initialization il y a 5 ans
La demande d'ajout a été fusionnée en 43609c8a21.
Connectez-vous pour rejoindre cette conversation.
Relecteurs
Demander une revue
Aucune évaluation
Étiquettes
Appliquer une étiquette
Effacer les étiquettes
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Pas d'étiquette GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Jalon
Affecter un jalon
Effacer le jalon
Pas d'élément
Aucun jalon
R14.0.6 release
Affecté à
Assigner des utilisateurs
Supprimer les affectations
Pas d'assignataires
2 participants
Notifications
Échéance

Aucune échéance n'a été définie.

Dépendances

No dependencies set.

Reference: TDE/tdelibs#24
Écrire Aperçu
Chargement…
Annuler
Enregistrer
Il n'existe pas encore de contenu.
Supprimer la branche 'feat/openssl-1.1-initialization'

Supprimer une branche est permanent. Cela NE PEUVENT être annulées. Continuer ?

Non
Oui