TDE
/
tdelibs
7
1
Fork 0
Código Issues 16 Pull requests 8 Versões Wiki Atividade
Etiquetas Marcos

Fix SSL initialization for OpenSSL >= 1.1 #24

Merge aplicado
SlavekB aplicou merge dos 1 commits de feat/openssl-1.1-initialization em master 5 anos atrás
Conversação 0 Commits 1 Arquivos alterados 1
SlavekB comentou 5 anos atrás
Proprietário

The SSL library is not linked but is dynamically loaded. Older SSL library initialization functions are for OpenSSL >= 1.1 only as macros in headers – to ensure compatibility at source code level. Therefore, searching for symbols for older functions can not be successful.

The proposed patch adds detection for initialization functions for OpenSSL >= 1.1.

The SSL library is not linked but is dynamically loaded. Older SSL library initialization functions are for OpenSSL >= 1.1 only as macros in headers – to ensure compatibility at source code level. Therefore, searching for symbols for older functions can not be successful. The proposed patch adds detection for initialization functions for OpenSSL >= 1.1.
SlavekB adicionou esta issue para o marco R14.0.6 release 5 anos atrás
MicheleC revisou 5 anos atrás
tdeio/kssl/kopenssl.cc Desatualizado
MicheleC comentou 5 anos atrás
Proprietário 
#if !defined(OPENSSL_INIT_ADD_ALL_CIPHERS)
# define OPENSSL_INIT_ADD_ALL_CIPHERS        0x00000004L
# define OPENSSL_INIT_ADD_ALL_DIGESTS        0x00000008L
# define OPENSSL_INIT_LOAD_CONFIG            0x00000040L
#endif

I think code would be more readable if these lines are moved before the function call or at the beginning of the files. They don't follow the if() block logic and in this place look a bit awkward, IMO

``` #if !defined(OPENSSL_INIT_ADD_ALL_CIPHERS) # define OPENSSL_INIT_ADD_ALL_CIPHERS 0x00000004L # define OPENSSL_INIT_ADD_ALL_DIGESTS 0x00000008L # define OPENSSL_INIT_LOAD_CONFIG 0x00000040L #endif ``` I think code would be more readable if these lines are moved before the function call or at the beginning of the files. They don't follow the if() block logic and in this place look a bit awkward, IMO
MicheleC aprovou estas alterações 5 anos atrás
MicheleC deixou um comentário
Proprietário

Looks good now :-)

Looks good now :-)
SlavekB fechou este pull request 5 anos atrás
SlavekB excluiu branch feat/openssl-1.1-initialization 5 anos atrás
O pull request teve merge aplicado como 43609c8a21.
Acesse para participar desta conversação.
Revisores
Solicitar revisão
Sem revisor
Etiquetas
Aplicar etiquetas
Limpar etiquetas
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
Sem etiqueta GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Marco
Definir marco
Limpar marco
Nenhum item
Sem marco
R14.0.6 release
Responsáveis
Atribuir usuários
Limpar responsáveis
Sem responsável
2 participante(s)
Notificações
Data limite

Data limite não informada.

Dependências

Nenhuma dependência definida.

Referência: TDE/tdelibs#24
Escrever Pré-visualização
Carregando…
Cancelar
Salvar
Ainda não há conteúdo.
Excluir Branch 'feat/openssl-1.1-initialization'

A exclusão de um branch é permanente. Isto NÃO PODERÁ ser desfeito. Continuar?

Não
Sim