標籤 里程碑

Fix SSL initialization for OpenSSL >= 1.1 #24

已合併

SlavekB 於 5 年之前 將 1 次代碼提交從 feat/openssl-1.1-initialization 合併至 master

對話內容 0 程式碼提交 1 Files Changed 1

SlavekB 評論 5 年之前

所有者

The SSL library is not linked but is dynamically loaded. Older SSL library initialization functions are for OpenSSL >= 1.1 only as macros in headers – to ensure compatibility at source code level. Therefore, searching for symbols for older functions can not be successful.

The proposed patch adds detection for initialization functions for OpenSSL >= 1.1.

The SSL library is not linked but is dynamically loaded. Older SSL library initialization functions are for OpenSSL >= 1.1 only as macros in headers – to ensure compatibility at source code level. Therefore, searching for symbols for older functions can not be successful. The proposed patch adds detection for initialization functions for OpenSSL >= 1.1.

SlavekB 新增至R14.0.6 release 里程碑 5 年之前

MicheleC reviewed 5 年之前

tdeio/kssl/kopenssl.cc Outdated

Show outdated Hide outdated

MicheleC 評論 5 年之前

所有者

#if !defined(OPENSSL_INIT_ADD_ALL_CIPHERS)
# define OPENSSL_INIT_ADD_ALL_CIPHERS        0x00000004L
# define OPENSSL_INIT_ADD_ALL_DIGESTS        0x00000008L
# define OPENSSL_INIT_LOAD_CONFIG            0x00000040L
#endif

I think code would be more readable if these lines are moved before the function call or at the beginning of the files. They don't follow the if() block logic and in this place look a bit awkward, IMO

``` #if !defined(OPENSSL_INIT_ADD_ALL_CIPHERS) # define OPENSSL_INIT_ADD_ALL_CIPHERS 0x00000004L # define OPENSSL_INIT_ADD_ALL_DIGESTS 0x00000008L # define OPENSSL_INIT_LOAD_CONFIG 0x00000040L #endif ``` I think code would be more readable if these lines are moved before the function call or at the beginning of the files. They don't follow the if() block logic and in this place look a bit awkward, IMO

MicheleC approved these changes 5 年之前

MicheleC left a comment

所有者

Looks good now :-)

Looks good now :-)

SlavekB closed this pull request 5 年之前

SlavekB 刪除分支 feat/openssl-1.1-initialization 5 年之前

The pull request has been merged as 43609c8a21.

登入 才能加入這對話。

Reviewers

Request review

No reviewers

標籤

Apply labels

清除已選取標籤

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

未選擇標籤 GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

里程碑

Set milestone

清除已選取里程碑

No items

未選擇里程碑

R14.0.6 release

Assignees

Assign users

Clear assignees

No Assignees

2 參與者

訊息

訂閱

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdelibs#24

Write Preview

Loading…

取消

儲存

尚未有任何內容