#64 Redirect some headers noticed by the compiler

Merged
SlavekB merged 1 commits from feat/header-redirections into master 3 weeks ago
selk commented 4 weeks ago
/usr/include/sys/poll.h:1:2: warning: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Wcpp]
    1 | #warning redirecting incorrect #include <sys/poll.h> to <poll.h>
/usr/include/sys/signal.h:1:2: warning: #warning redirecting incorrect #include <sys/signal.h> to <signal.h> [-Wcpp]
    1 | #warning redirecting incorrect #include <sys/signal.h> to <signal.h>

Note: <sys/signal.h> has been removed from the tdeio/tdeio/connection.cpp source - it was already declared.
``` /usr/include/sys/poll.h:1:2: warning: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Wcpp] 1 | #warning redirecting incorrect #include <sys/poll.h> to <poll.h> /usr/include/sys/signal.h:1:2: warning: #warning redirecting incorrect #include <sys/signal.h> to <signal.h> [-Wcpp] 1 | #warning redirecting incorrect #include <sys/signal.h> to <signal.h> Note: <sys/signal.h> has been removed from the tdeio/tdeio/connection.cpp source - it was already declared. ```
SlavekB commented 3 weeks ago
Owner

Here's an interesting situation with sys/poll.h × poll.h:

  • On Linux (glibc) poll.h contains #include <sys/poll.h>, so the real file is really in `sys/poll.h
  • On FreeBSD poll.h is symlink to sys/poll.h, so the real file is really in sys/poll.h.

The mentioned incorrect seems to be on many systems as a real true file location. That's why I'm a little hesitant about what's right.

In any case, the test on Debian and FreeBSD is without problems.

Here's an interesting situation with `sys/poll.h` × `poll.h`: * On Linux (glibc) `poll.h` contains `#include <sys/poll.h>`, so the real file is really in `sys/poll.h * On FreeBSD `poll.h` is symlink to `sys/poll.h`, so the real file is really in `sys/poll.h`. The mentioned *incorrect* seems to be on many systems as a real true file location. That's why I'm a little hesitant about what's right. In any case, the test on Debian and FreeBSD is without problems.
selk commented 3 weeks ago
Poster
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/poll.h.html#tag_13_34
SlavekB commented 3 weeks ago
Owner

Please can you rebase to the current HEAD so that your GPG signature can be preserved when merged?

Please can you rebase to the current HEAD so that your GPG signature can be preserved when merged?
selk commented 3 weeks ago
Poster

Done. :+1:

Done. :+1:
SlavekB deleted branch feat/header-redirections 3 weeks ago
SlavekB added this to the R14.0.8 release milestone 3 weeks ago
The pull request has been merged as c2adce2e13.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.