Improve folder icons on the speedbar #71
Manually merged
SlavekB
merged 1 commits from feat/file-speedbar-icons
into master
4 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/file-speedbar-icons'
Deleting a branch is permanent. It CANNOT be undone. Continue?
After the recent update, there are three identical icons (
folder_txt
) in the speedbar in the file dialog. I modified the icons to make them more accurate. For example, we have a nice desktop icon, the documents folder on the desktop has its own icon, the public folder could be open,… What do you think?Looks good to me. If @Chris is happy, we can later merge.
@Chris is happy about too. 😸
But I would also like folder_txt a bit more for templates, because it would maybe fit better if we have additional desktop icons you can activate, like we have for documents already. Someone would open it if he want's to write something (from a template), but otherwise, it could be puzzled with documents by that icon?
Public is fine. 👍
I would also suggest some ordering, but might be we better talk about that order in another PR? Netherless, I would suggest: "Desktop, Documents, Downloads, Pictures, Musik, Videos, Public, Templates then." What do you think about? Because templates should be last.
Regarding the icons, the discussion seems to be for templates only.
The
folder_txt
icon made me feel a bit confusing, because we don't usually write into templates, they're like read-only – they're copied. Therefore I chosefolder_gray
– templates are general, uninteresting, gray 😺Together with @Chris we tried to find some more suitable icon, but we couldn't find anything better than
folder_txt
andfolder_gray
.Which one do you prefer?
Regarding the order of the icons, I have no objections. There it makes sense to me that the first is Home, and that the dynamically added icons are at the end.
We discussed order along with @Chris and it was seen that the opinions of individual users may be different. Therefore, a simple alphabetical order (although the original English names) appears to be the least conflicting 😉
Yes, I am fine with @MicheleC making the final decision here, or has maybe some better suggestion? 👍
The order I set in the code is simple. First home, then the other folders in alphabetical order. If you prefer a different one no problem, we just need to reorder a few lines of code. Feel free to go ahead 👍
017a50624b
.