KMix system tray icon enhancements #31

This PR makes the following changes to the KMix system tray icon:

Standard icon names with volume level specification (low, medium, high)
Support for volume icons from system theme
Choice between new theme with volume levels (Crystal), old theme (Classic - Old Crystal) and system theme.

This PR is like tdetoys#18 is for KWeather.

30 KiB

Long ago there was a suggestion from someone (Darrell?) to have a volume bar next to the volume icon, similar to the battery level bar near tdepowersave icon.

@SlavekB @blu.256
Should we consider that solution instead of the one proposed here?

The bar suggestion is surely nice, but IMO we can have both and leave the choice to the user. This PR will make KMix consistent with the icon theme picked by the user, with the added bonus that the original icon theme becomes more detailed and gives the user a rough idea of the volume. Somebody might not want the level of detail of the bar.

The same, actually, can also be done with tdepowersave: give the userthe choice to either use the bar, or the theme's status icons, or tdepowersave's own fallback icons (IDK if they exist).

Sounds good, nice suggestion.

I did a test and it seems good. Given this is a change on the UI of an important component, I propose we give the user a choice among:

classic icons (same as original icons)
new crystal icons (this PR)
system icons
What do you think?

@blu.256
Hi Philippe, any update on this? The idea is good and would be good to add it to at least R14.1.0 or maybe also R14.0.x.

@MicheleC Hello Michele, I am busy lately and maybe prioritise tdelibs#152 over this, as it is related to TDEMarkdown and many places where SVG icons don't show properly (such as KWeather and Konqueror).

From what I remember the code of the preferences dialog is a pain to change (as is all of KMix btw), so I was just thinking to also recreate the settings dialog with .ui files and possibly TDEConfig XT, this would make things so much easier.

I'll inform you when I'm up to this PR and I would appreciate your opinion on the point I made above.

Sure, no problem. Great wiki page on TDEConfig XT btw!

@MicheleC I have finally finalized this PR with the option to select between three icon themes (new Crystal, old Crystal and system) according to your feedback.

I will do another test and feedback. May end up being during next weekend, so please be patient :-)

I did not test, but there are two small things to fix.

I did a new test. Looks nice and works well. Perhaps we could fine tune the thresholds to 33 and 67 instead of 35 and 70, but it is a minor point and I am fine either way.
Good work Philippe!

Follow up wishlist issue #69 would be nice to fix. Philippe, I remember you already did some work on transparency for the kxkb tool icons, so perhaps the changes are easy to implement.

I didn't do a test, but it looks good – I don't have other objections.
You can consider a proposal for a small change in thresholds, as it states @MicheleC

Beside the small proposal on thresholds, don't forget to rebase before merging @blu.256

@blu.256 reminder that this PR seems ready to merge. If possible adjust the two threshold as we commented above, but other than that you can proceed with merging it.

Merged and backported for R14.1.2.
P.S. Thresholds were adjusted.

Great, well done!

KMix system tray icon enhancements #31

Reviewers