A function of appending new symbols to the actual X-server keymap #12

Merged
MicheleC merged 1 commits from bug3014 into master 5 years ago
roman commented 5 years ago
Collaborator

The new function of registering-appending the new entered keys

The modern X-server (seems after xorg-server 1.10) changed itself behavior in treating keymaps, what impact to VNC and made impossible to type into VNC for different from the base-first keyboard layout keys.

x11vnc, far ago, resolved this behavior appending a function of registering-appending the new entered keys, which clean, together with restoring all other layouts, at the VNC session finish.

So, I have appended this new function to KRFB by this included patch.

The new function of registering-appending the new entered keys The modern X-server (seems after xorg-server 1.10) changed itself behavior in treating keymaps, what impact to VNC and made impossible to type into VNC for different from the base-first keyboard layout keys. x11vnc, far ago, resolved this behavior appending a function of registering-appending the new entered keys, which clean, together with restoring all other layouts, at the VNC session finish. So, I have appended this new function to KRFB by this included patch.
Owner

The patch looks good.

Please add an entry to the git log like: This resolves bug 3014 and issue #11. – to ensure that link in the TGW is created as well as the Bugzilla link in the changelog listing.

Also, when using git --amend to add a git log, be sure to use -s to add a Signed-off line. Then you can use git push --force on your branch.

The patch looks good. Please add an entry to the git log like: *This resolves bug 3014 and issue #11.* – to ensure that link in the TGW is created as well as the Bugzilla link in the changelog listing. Also, when using `git --amend` to add a git log, be sure to use `-s` to add a Signed-off line. Then you can use `git push --force` on your branch.
roman commented 5 years ago
Poster
Collaborator

Please add an entry to the git log like: This resolves bug 3014 and issue #11. – to ensure that link in the TGW is created as well as the Bugzilla link in the changelog listing.

Done

> Please add an entry to the git log like: This resolves bug 3014 and issue #11. – to ensure that link in the TGW is created as well as the Bugzilla link in the changelog listing. Done
Owner

I'll probably look like I'm still dissatisfied. Link to bug and issue is good, DCO approval is good. However, I meant to add this information to the previous description of what the commit solves, not to replace it 😸

Please, you can now add at to the top of git log something like krfb: Add a function for appending new symbols to the actual X-server keymap

I'll probably look like I'm still dissatisfied. Link to bug and issue is good, DCO approval is good. However, I meant to *add* this information to the previous description of what the commit solves, not to replace it :smile_cat: Please, you can now add at to the top of git log something like *krfb: Add a function for appending new symbols to the actual X-server keymap*
roman commented 5 years ago
Poster
Collaborator

Check now, please!

Check now, please!
Owner

Absolutely perfect – you now already know, commit log can be multiline. Thank you.

Absolutely perfect – you now already know, commit log can be multiline. Thank you.
MicheleC closed this pull request 5 years ago
MicheleC deleted branch bug3014 5 years ago
MicheleC added this to the R14.0.7 release milestone 5 years ago
Owner

Thanks Roman!

Thanks Roman!
The pull request has been merged as b75ba2ef0d.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdenetwork#12
Loading…
There is no content yet.