kopete: Added ability to build with shared tqca library. #23

Manually merged
SlavekB merged 1 commits from feat/use-shared-tqca into master 4 years ago
Owner

Added support for building with the tqca shared library with the ability to use the previous two built-in copies of tqca to ensure a smooth transition to the shared library.

Therefore, the built-in files have been renamed from qca* to tqca*.

This relates to TDE/tqca#2.

Added support for building with the tqca shared library with the ability to use the previous two built-in copies of tqca to ensure a smooth transition to the shared library. Therefore, the built-in files have been renamed from qca* to tqca*. This relates to TDE/tqca#2.
SlavekB added the PR/rfc label 4 years ago
Owner

Few notes:

  1. many changes are required, so I think it would be clean to have a different approach. For example in R14.0.x we should keep the existing built-in library, since otherwise it would be quite a change to package structures. While in R14.1.0-DEV we could go directly with the shared library approach, removing the built-in version. Since it is teh development branch, I don't see a particular need for a transition period, it is not a stable branch.

  2. In that case, we would need some changes also in tde packaging to add dependency on tqca trinity shared library

Few notes: 1. many changes are required, so I think it would be clean to have a different approach. For example in R14.0.x we should keep the existing built-in library, since otherwise it would be quite a change to package structures. While in R14.1.0-DEV we could go directly with the shared library approach, removing the built-in version. Since it is teh development branch, I don't see a particular need for a transition period, it is not a stable branch. 2. In that case, we would need some changes also in tde packaging to add dependency on tqca trinity shared library
Poster
Owner

Yesterday I have already added the tqca packaging files to both the master and r14.0.x branch. So now the shared libtqca library is already in both PTB and PSB. It would be a little awkward to reverse it now in r14.0.x branch 😿

Yesterday I have already added the tqca packaging files to both the master and r14.0.x branch. So now the shared libtqca library is already in both PTB and PSB. It would be a little awkward to reverse it now in r14.0.x branch :crying_cat_face:
Poster
Owner

For the sake of completeness: Although changed seems to be many, in fact there are very few changes – just in connection with renaming qca to tqca. Therefore, it is not a fundamental change. Most only small one-line changes.

Removing built-in copies of tqca is intended for the master branch. There will be a short transition period when it will be possible to build in both ways – giving package managers time to modify their scripts and dependencies.

For the sake of completeness: Although changed seems to be many, in fact there are very few changes – just in connection with renaming qca to tqca. Therefore, it is not a fundamental change. Most only small one-line changes. Removing built-in copies of tqca is intended for the master branch. There will be a short transition period when it will be possible to build in both ways – giving package managers time to modify their scripts and dependencies.
SlavekB closed this pull request 4 years ago
SlavekB closed this pull request 4 years ago
SlavekB removed the PR/rfc label 4 years ago
SlavekB deleted branch feat/use-shared-tqca 4 years ago
SlavekB added this to the R14.0.8 release milestone 4 years ago
The pull request has been manually merged as 1037d38623.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdenetwork#23
Loading…
There is no content yet.