Improve portabilities #7
Merged
SlavekB
merged 1 commits from feat/improve-portability
into master
5 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/improve-portability'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Fixes some potential build issues for minor platforms.
It seems you forgot to use Sign-off-by for the last commit 😸
It looks good. Just one small comment – see below.
##### include essential cmake modules ###########
include( FindPkgConfig )
include( CheckSymbolExists )
This same
include( CheckSymbolExists )
is located two lines below.My patchset is based on R14.0.4, so I was waiting R14.0.5 taballs to refine patches before sending pull requests, but ... :(
Oh, I understand. We are also sad that we cannot publish official source tarballs. Thank you for updating PR.
One test seems to be missing.
endif( )
check_symbol_exists( strlcat "string.h" HAVE_STRLCAT_PROTO )
check_symbol_exists( strlcpy "string.h" HAVE_STRLCPY_PROTO )
It seems we need to add a test for
HAVE_STRERROR
here, because I see this test only in libtdevnc, but it uses a different constant:It will be a good idea to add a separate test, independent of libtdevnc.
Just a general comment. Why working out of R14.0.4 tarballs which are about 2 years old? You can clone the latest code (either for master or R14.0.x) from here and always have the latest updates on both 😄
"Pull request" means "clone the latest code" and "modify" then "push",
not "sending patches for R14.0.4".
I'm a user, so usually using release tarball.
I've packaged R14.0.4 locally, but too busy after that and too far from the master branch, so mssing PRs.
After R14.0.5, I've update patches for the release and start to send pull request,
but too busy and stalled, then too late to R14.0.6.
I have little free time now, so I want to update my patches for R14.0.6
then create PR, but no release tarball yet, then start to merge patches
to master branch, but it is nasty work.
No problem Obata-san.
Yes, there are currently some delays with the tarball release (long story, unfortunately) for which Slavek and I can't do much 😞 hopefully situation will change in the future, but till then we have to carry on the best we can.
Hi Obache,
Here is that kind of "discussion" I've had with a guy, on the official Slackware forum, whom was desperate to get the official R14.0.6 tarballs.
https://www.linuxquestions.org/questions/slackware-14/tde-trinity-14-0-4-for-slackware-14-2-x64-4175597797/page4.html#post5981952
At the moment basically you've got two choices: either using git, get the whole thing and switch to r14.0.6 or downloading each packages (archives) through different locations.
In addition to this post, know that I'm very interested in what you do here because I'd love to give NetBSD a spin with TDE.
Can you share your pkgsrc packages (even with R14.0.4/5)?
@obache, I don't know if it can be useful for you, but for FreeBSD ports I use source tarballs from TDE Debian packages. For these, the advantage is that they are always available along with the release. See: FreeBSD in tde-packaging
I would like to say thanks to everyone.
It is just my laziness, almost works fine here.
@cethyel, Please write off about XXX-package-system, it is a waste of time.
Oh my goodness!
I didn't know we had porn-package-system, if I had knew that, I would have been more thorough looking at it...
Can you rephrase that? I can't make sense out of it.
@cethyel Yes, it's R45 package system, not for young people :-)
XXX does not have so meanings, just ×××, ○○○, □□□, and so on.
7537d9ef7d
.