#3 change exec_process to execute_process

Merged
SlavekB merged 1 commits from issue/2/exec_process into master 7 months ago
cethyel commented 7 months ago

This should bring back xmms in the game.

Xmms is still provided within Slackware and should be in the next release (Slackware-15.0)

This should bring back xmms in the game. Xmms is still provided within Slackware and should be in the next release (Slackware-15.0)
SlavekB commented 7 months ago
Owner

I’m not sure why the XMMS_CLFAGS and XMMS_LIBS variables are set before calling xmms_config? Why are parameters not entered directly in a call? Setting these variables seems to me unnecessary.

I'm not sure why the `XMMS_CLFAGS` and `XMMS_LIBS` variables are set before calling `xmms_config`? Why are parameters not entered directly in a call? Setting these variables seems to me unnecessary.
cethyel commented 7 months ago
Poster

either through a variable or within ‘ ‘, --cflags and --libs have to be enclosed. I get errors otherwise.

It also works like this:

set( HAVE_XMMS 1 )
EXECUTE_PROCESS( COMMAND ${XMMS_CONFIG} '--cflags' OUTPUT_VARIABLE XMMS_INCLUDES )
EXECUTE_PROCESS( COMMAND ${XMMS_CONFIG} '--libs'   OUTPUT_VARIABLE XMMS_LIBS     )

Do you prefer that way?

either through a variable or within ' ', --cflags and --libs have to be enclosed. I get errors otherwise. It also works like this: ``` set( HAVE_XMMS 1 ) EXECUTE_PROCESS( COMMAND ${XMMS_CONFIG} '--cflags' OUTPUT_VARIABLE XMMS_INCLUDES ) EXECUTE_PROCESS( COMMAND ${XMMS_CONFIG} '--libs' OUTPUT_VARIABLE XMMS_LIBS ) ``` Do you prefer that way?
SlavekB commented 7 months ago
Owner

Yes, I prefer this way without variables. Do you make a change in commit?

Note: Do not be afraid to use ammend on an existing patch and then push using --force

Yes, I prefer this way without variables. Do you make a change in commit? Note: Do not be afraid to use ammend on an existing patch and then push using --force
cethyel commented 7 months ago
Poster

Ok, I’ll have a shot at “ammend” and…and pussssh…

Ok, I'll have a shot at "ammend" and...and pussssh...
MicheleC commented 7 months ago
Owner

git push -f origin HEAD :wink:

git push -f origin HEAD :wink:
MicheleC commented 7 months ago
Owner

if you want to modify your previous commit, do as follow:

1) create new commit with additional changes

2) git reset --soft <commit before all your commits>

3) git commit

This will create a new single commit with all your previous changes.

Then:

git push -f origin HEAD

if you want to modify your previous commit, do as follow: 1) create new commit with additional changes 2) git reset --soft \<commit before all your commits\> 3) git commit This will create a new single commit with all your previous changes. Then: git push -f origin HEAD
cethyel commented 7 months ago
Poster

didn’t work. ok, learning the next thousand git cmd is on my TODO list

didn't work. ok, learning the next thousand git cmd is on my TODO list
SlavekB commented 7 months ago
Owner

Here are several options:

  1. Make a new commit and then use rebase to squash.
  2. Make new changes, use git add --all and then git commit --amend
  3. Make git reset HEAD~1 and continue as if the previous commit did not exist
Here are several options: 1. Make a new commit and then use rebase to squash. 2. Make new changes, use `git add --all` and then `git commit --amend` 3. Make `git reset HEAD~1` and continue as if the previous commit did not exist
cethyel commented 7 months ago
Poster

I’ve deleted everything, I’m done for today and that shitty git.

I've deleted everything, I'm done for today and that shitty git.
SlavekB commented 7 months ago
Owner

Small note: For a branch name, use only the issue number without #. As Gitea tries to parse #number as a reference to issue / pull-request, then using # in the branch name leads to a cyclical link.

Small note: For a branch name, use only the issue number without #. As Gitea tries to parse #number as a reference to issue / pull-request, then using # in the branch name leads to a cyclical link.
SlavekB commented 7 months ago
Owner

Merged and pushed upstream.

Merged and pushed upstream.
SlavekB deleted branch issue/2/exec_process 7 months ago
SlavekB added this to the R14.0.6 release milestone 7 months ago
The pull request has been merged.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.