change exec_process to execute_process #3

This should bring back xmms in the game.

Xmms is still provided within Slackware and should be in the next release (Slackware-15.0)

I'm not sure why the XMMS_CLFAGS and XMMS_LIBS variables are set before calling xmms_config? Why are parameters not entered directly in a call? Setting these variables seems to me unnecessary.

either through a variable or within ' ', --cflags and --libs have to be enclosed. I get errors otherwise.

It also works like this:

set( HAVE_XMMS 1 )
EXECUTE_PROCESS( COMMAND ${XMMS_CONFIG} '--cflags' OUTPUT_VARIABLE XMMS_INCLUDES )
EXECUTE_PROCESS( COMMAND ${XMMS_CONFIG} '--libs'   OUTPUT_VARIABLE XMMS_LIBS     )

Do you prefer that way?

Yes, I prefer this way without variables. Do you make a change in commit?

Note: Do not be afraid to use ammend on an existing patch and then push using --force

Ok, I'll have a shot at "ammend" and...and pussssh...

git push -f origin HEAD 😉

if you want to modify your previous commit, do as follow:

create new commit with additional changes
git reset --soft <commit before all your commits>
git commit

This will create a new single commit with all your previous changes.

Then:

git push -f origin HEAD

didn't work.
ok, learning the next thousand git cmd is on my TODO list

Here are several options:

Make a new commit and then use rebase to squash.
Make new changes, use git add --all and then git commit --amend
Make git reset HEAD~1 and continue as if the previous commit did not exist

I've deleted everything, I'm done for today and that shitty git.

Small note: For a branch name, use only the issue number without #. As Gitea tries to parse #number as a reference to issue / pull-request, then using # in the branch name leads to a cyclical link.

Merged and pushed upstream.