New Issue

KMail: Attachments containing '#' cannot be opened #119

Open

opened by pschwabauer · 3 comments

pschwabauer commented

Collaborator

Description

All characters after the '#' in the filename will be truncated. Because of this, it is not possible to open attachments that contain this character.

For example, if the filename is test#test.png, KMail will open /tmp/xxx/test and not /tmp/xxx/test#test.png. If the filename is #test.png, it will try to open /tmp/xxx.

The reason is that in KMReaderWin::tempFileUrlFromPartNode the file path is not correctly escaped.
See the documentation for KURL on how to properly escape the file path: https://trinitydesktop.org/docs/trinity/tdelibs/tdecore/html/classKURL.html#details

Steps to reproduce

Write a mail and attach an image with the filename test#test.png
Send and open the mail
Try to open the attachment

MicheleC commented

Owner

@pschwabauer will you work on a fix for this?

pschwabauer commented

Poster

Collaborator

@pschwabauer will you work on a fix for this?

Yes, I will submit a pull request in the coming days.

MicheleC commented

Owner

Great, thank you. Keep in mind we are under soft freeze for R14.1.2, so the PR will be merged after that and will end up in R14.1.3.

pschwabauer referenced this issue from a commit

Fix attachment filename handling

pschwabauer referenced this issue

Fix attachment filename handling #120

pschwabauer referenced this issue from a commit

Fix attachment filename handling

SlavekB referenced this issue from a commit

Fix attachment filename handling

Sign in to join this conversation.

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdepim#119