WIP: bug/2719 libkcal tests #17

Closed
deloptes wants to merge 1 commits from bug/2719/libkcaltests into master
Collaborator

I basically move bug#2719 here to discuss and follow up.

I used tde_add_check_executable and tests are build and run only if make check is used. However tde_add_check_executable seems does not support DEPENDS and I could not find out how I can add the custom commands to the check target. I used custom target, which I unfortunately had to add to ALL. If you have better way, let me know.

@SlavekB tests are still failing as you noticed in bugzilla. This needs closer look.

I have also additional problem, because the tests use DCOP and I run the build in non-GUI env. I am not sure what is the proper way to run the tests.
It looks like the tests need closer investigation.

Subsequently tests can be run with "make test" as pointed out by Fat-Zer here: http://trinity-devel.pearsoncomputing.net/?0::15130

And this is an example

repo-test/tde/2_build/tdepim/obj-x86_64-linux-gnu$ make test
Running tests...
/usr/bin/ctest --force-new-ctest-process
Test project /mnt/DEVELOPMENT/TDE/repo-test/tde/2_build/tdepim/obj-x86_64-linux-gnu
    Start 1: test1
1/6 Test #1: test1 ............................***Failed    9.31 sec
    Start 2: test2
2/6 Test #2: test2 ............................***Failed    8.94 sec
    Start 3: test3
3/6 Test #3: test3 ............................   Passed    9.52 sec
    Start 4: test4
4/6 Test #4: test4 ............................***Failed    0.44 sec
    Start 5: test5
5/6 Test #5: test5 ............................   Passed    0.79 sec
    Start 6: test6
6/6 Test #6: test6 ............................***Failed    0.80 sec

33% tests passed, 4 tests failed out of 6

Total Test time (real) =  29.81 sec

The following tests FAILED:
          1 - test1 (Failed)
          2 - test2 (Failed)
          4 - test4 (Failed)
          6 - test6 (Failed)
Errors while running CTest
Makefile:130: recipe for target 'test' failed

I basically move bug#2719 here to discuss and follow up. I used tde_add_check_executable and tests are build and run only if make check is used. However tde_add_check_executable seems does not support DEPENDS and I could not find out how I can add the custom commands to the check target. I used custom target, which I unfortunately had to add to ALL. If you have better way, let me know. @SlavekB tests are still failing as you noticed in bugzilla. This needs closer look. I have also additional problem, because the tests use DCOP and I run the build in non-GUI env. I am not sure what is the proper way to run the tests. It looks like the tests need closer investigation. Subsequently tests can be run with "make test" as pointed out by Fat-Zer here: http://trinity-devel.pearsoncomputing.net/?0::15130 And this is an example ``` repo-test/tde/2_build/tdepim/obj-x86_64-linux-gnu$ make test Running tests... /usr/bin/ctest --force-new-ctest-process Test project /mnt/DEVELOPMENT/TDE/repo-test/tde/2_build/tdepim/obj-x86_64-linux-gnu Start 1: test1 1/6 Test #1: test1 ............................***Failed 9.31 sec Start 2: test2 2/6 Test #2: test2 ............................***Failed 8.94 sec Start 3: test3 3/6 Test #3: test3 ............................ Passed 9.52 sec Start 4: test4 4/6 Test #4: test4 ............................***Failed 0.44 sec Start 5: test5 5/6 Test #5: test5 ............................ Passed 0.79 sec Start 6: test6 6/6 Test #6: test6 ............................***Failed 0.80 sec 33% tests passed, 4 tests failed out of 6 Total Test time (real) = 29.81 sec The following tests FAILED: 1 - test1 (Failed) 2 - test2 (Failed) 4 - test4 (Failed) 6 - test6 (Failed) Errors while running CTest Makefile:130: recipe for target 'test' failed ```
MicheleC added this to the R14.1.0 release milestone 5 years ago
Owner

Will be working on this Emanoil. Should have something ready in the next few days...

Will be working on this Emanoil. Should have something ready in the next few days...
Owner

Will be working on this Emanoil. Should have something ready in the next few days...

Will be working on this Emanoil. Should have something ready in the next few days...
Poster
Collaborator

Thanks! I am under water at the moment and can not spend any time, but let me know if you have something to add.
Especially the test.sh script emerged from the previous scripts inherited by the past - it is not nice, but a rewrite seemed to be time consuming.

Thanks! I am under water at the moment and can not spend any time, but let me know if you have something to add. Especially the test.sh script emerged from the previous scripts inherited by the past - it is not nice, but a rewrite seemed to be time consuming.
Owner

I have prepared a new patch that does not require the test.sh script nor the libkcaltests target. It also takes care of the zoneinfo thing properly. I will create separate PR for that soon.

I have prepared a new patch that does not require the test.sh script nor the libkcaltests target. It also takes care of the zoneinfo thing properly. I will create separate PR for that soon.
Owner

Closed and replaced by #18.

Closed and replaced by #18.
MicheleC closed this pull request 5 years ago
MicheleC removed this from the R14.1.0 release milestone 5 years ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdepim#17
Loading…
There is no content yet.