TDE
/
tdepim
6
0
Fork 1
Code Issues 23 Pull Requests 5 Releases Wiki Activity
Labels Milestones

Backports of various bugfixes in KDE 4 #20

Closed
luke-jr wants to merge 17 commits from luke-jr/tdepim:kde4_backports into master
Conversation 2 Commits 17 Files Changed 13
luke-jr commented 5 years ago
Collaborator

For some reason I forget, I have NOT been testing these... There may or may not be issues.

For some reason I forget, I have NOT been testing these... There may or may not be issues.
MicheleC commented 5 years ago
Owner

ok, thanks for letting us know that. we will take a closer look before to all those commits then 👍

ok, thanks for letting us know that. we will take a closer look before to all those commits then :+1:
MicheleC commented 5 years ago
Owner

14 out of 17 commits have been merged to master.
Commits 73c39fc5e6 and f43302d955 do not really add any value expect for one more message in the build log, so Slavek and I have decided not to merge them.
Commit 9410e570d0 does not make any functional difference to the code, so the commit message seems wrong, since there is no array out of bound.

Luke, thanks for all these commitS 👍

14 out of 17 commits have been merged to master. Commits 73c39fc5e6 and f43302d955 do not really add any value expect for one more message in the build log, so Slavek and I have decided not to merge them. Commit 9410e570d0 does not make any functional difference to the code, so the commit message seems wrong, since there is no array out of bound. Luke, thanks for all these commitS :+1:
MicheleC closed this pull request 5 years ago
MicheleC added this to the R14.0.7 release milestone 5 years ago
Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.7 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdepim#20
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'luke-jr/tdepim:kde4_backports'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes