TDE
/
tdepim
6
0
Fork 1
Code Issues 23 Pull Requests 5 Releases Wiki Activity
Labels Milestones
New Issue

Minimal requirement version of gnokii? #56

Closed
opened 3 years ago by obache · 6 comments
obache commented 3 years ago
Collaborator

Basic information

  • TDE version:
  • Distribution:
  • Hardware:

Description

Currently, gnokii will be checked with pkg_search_module

4ad5e8c72c/ConfigureChecks.cmake (L58-L63)

It will use pkg-config, and gnokii.pc is provided by gnokii version 0.6.13 or later.

In tdepim/kaddressbook/xxport/gnokii_xxport.cpp

4ad5e8c72c/kaddressbook/xxport/gnokii_xxport.cpp (L35-L44)

HAVE_GNOKII_H is used but never checked with CMake.
Addiitonnaly, "version 0.6.13 or later" is suggested, but currently only such version are detected as described above.

0.6.12 or older version must be supported?

If so, ConfigureChecks.cmake should be changed to detect even if missing gnokii.pc, and declear HAVE_GNOKII_H for newer version.

If not, using parts such as gnokii_xxport.cpp should be changed as using codes for 0.6.13 or later unconditionally, and remove codes for older releases.

Steps to reproduce

  1. configure and build with BUILD_KADDRESSBOOK=ON
  2. rise warnings missing and older gnokii even if using newser version with development header and libraries

Screenshots

<!-- This is a comment. Please fill in the required fields below. The comments provide instructions on how to do so. Note: You do not need to remove comments. --> ## Basic information - TDE version: <!-- such as R14.0.9 - see tde-config -v --> - Distribution: <!-- such as Debian Stretch - see lsb_release -sd --> - Hardware: <!-- amd64 / i386 / armhf / ... --> <!-- Use SL/* labels to set the severity level. Please do not set a milestone. --> ## Description Currently, gnokii will be checked with ` pkg_search_module` https://mirror.git.trinitydesktop.org/gitea/TDE/tdepim/src/commit/4ad5e8c72cf9c6956a326c6011ef3cfad7bb78c3/ConfigureChecks.cmake#L58-L63 It will use `pkg-config`, and `gnokii.pc` is provided by gnokii version 0.6.13 or later. In tdepim/kaddressbook/xxport/gnokii_xxport.cpp https://mirror.git.trinitydesktop.org/gitea/TDE/tdepim/src/commit/4ad5e8c72cf9c6956a326c6011ef3cfad7bb78c3/kaddressbook/xxport/gnokii_xxport.cpp#L35-L44 `HAVE_GNOKII_H` is used but never checked with CMake. Addiitonnaly, "version 0.6.13 or later" is suggested, but currently only such version are detected as described above. 0.6.12 or older version must be supported? If so, ConfigureChecks.cmake should be changed to detect even if missing gnokii.pc, and declear HAVE_GNOKII_H for newer version. If not, using parts such as `gnokii_xxport.cpp` should be changed as using codes for 0.6.13 or later unconditionally, and remove codes for older releases. ## Steps to reproduce 1. configure and build with BUILD_KADDRESSBOOK=ON 2. rise warnings missing and older gnokii even if using newser version with development header and libraries ## Screenshots <!-- If it seems useful, please provide provide one or more screenshots. -->
deloptes commented 3 years ago
Collaborator

Does someone use gnokii? Does it have any application in todays world?

Just asking.

Does someone use gnokii? Does it have any application in todays world? Just asking.
MicheleC commented 3 years ago
Owner

Does someone use gnokii? Does it have any application in todays world?

I don't use it but I see the package still available in debian repos... I guess we can assume someone is still looking after it

> Does someone use gnokii? Does it have any application in todays world? I don't use it but I see the package still available in debian repos... I guess we can assume someone is still looking after it
SlavekB commented 3 years ago
Owner

Does someone use gnokii? Does it have any application in todays world?

I don't use it but I see the package still available in debian repos... I guess we can assume someone is still looking after it

Because there is a build option WITH_GNOKII, then it is in place to test for gnokii as needed to be properly functional.

> > Does someone use gnokii? Does it have any application in todays world? > > I don't use it but I see the package still available in debian repos... I guess we can assume someone is still looking after it Because there is a build option `WITH_GNOKII`, then it is in place to test for gnokii as needed to be properly functional.
SlavekB closed this issue 3 years ago
deloptes commented 3 years ago
Collaborator

This is precisly why I was asking about this, but it looks like it might be still possible to send/read SMS with it.

This is precisly why I was asking about this, but it looks like it might be still possible to send/read SMS with it.
MicheleC commented 3 years ago
Owner

Fixed by PR #57.

Fixed by PR #57.
SlavekB added this to the R14.0.11 release milestone 3 years ago
obache commented 3 years ago
Poster
Collaborator

It will use pkg-config, and gnokii.pc is provided by gnokii version 0.6.13 or later.

I is wrong, xgnokii.pc is provided by gnokii version 0.6.13 or later,
but gnokii.pc is version 0.5.0 or later.

0.6.12 or older version must be supported?

0.4.x or older version must be supported?

Yes, no need to support over 19 years old releases.

> It will use `pkg-config`, and `gnokii.pc` is provided by gnokii version 0.6.13 or later. I is wrong, `xgnokii.pc` is provided by gnokii version 0.6.13 or later, but `gnokii.pc` is version 0.5.0 or later. > 0.6.12 or older version must be supported? 0.4.x or older version must be supported? Yes, no need to support over 19 years old releases.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
disable-actions-due-to-folder-loading
issue/119/filename-escape
r14.1.x
master
bug/94/open-html
feat/korganizer
feat/karm-busyCntr-itemReset
r14.0.x
v3.5.13-sru
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.11 release
Assignees
Assign users
Clear assignees
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdepim#56
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes