Fixed libkcal tests (new version) - bug 2719 #18

Replaces #17.

Under Debian/Ubuntu, to be built with TDE/tde-packaging#15

Marked as WIP until tests are fixed, otherwise building tdepim would fail.

PR is now completed and works fine in Debian Buster.

100% tests passed, 0 tests failed out of 455

@SlavekB: can you run a test on all distros and see if all tests pass?

Score of builds is not good:

     18 FAILED
      8 SUCCESS

I think it's related to commit 8996740084. maybe redundant is_utc is still needed to use for libical < 3 because it is used internally in libical? Or something wrong with function icaltime_from_timet_with_zone?

Successful builds are for distributions that contain libical >= 3 (Buster, Bionic, Cosmic, Disco), failing are all that contain libical < 3. 19 tests fail on older distributions (Squeeze, Wheezy, Lucid, Precise), 13 on newer distributions (same starting from test 443):

The following tests FAILED:
         61 - testrecurrence__next__data/RecurrenceRule/LibICal/LibICal_TestCase55.ics__ (Failed)
         62 - testrecurrence__next__data/RecurrenceRule/LibICal/LibICal_TestCase54.ics__ (Failed)
         97 - testrecurrence__next__data/RecurrenceRule/LibICal/LibICal_TestCase15.ics__ (Failed)
        204 - testrecurprevious__prev__data/RecurrenceRule/LibICal/LibICal_TestCase55.ics__ (Failed)
        205 - testrecurprevious__prev__data/RecurrenceRule/LibICal/LibICal_TestCase54.ics__ (Failed)
        240 - testrecurprevious__prev__data/RecurrenceRule/LibICal/LibICal_TestCase15.ics__ (Failed)
        443 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase13.vcs__ (Failed)
        444 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase12.vcs__ (Failed)
        445 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase11.vcs__ (Failed)
        446 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase10.vcs__ (Failed)
        447 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase09.vcs__ (Failed)
        448 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase08.vcs__ (Failed)
        449 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase07.vcs__ (Failed)
        450 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase06.vcs__ (Failed)
        451 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase05.vcs__ (Failed)
        452 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase04.vcs__ (Failed)
        453 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase03.vcs__ (Failed)
        454 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase02.vcs__ (Failed)
        455 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase01.vcs__ (Failed)

Score of builds is not good: ``` 18 FAILED 8 SUCCESS ``` I think it's related to commit 8996740084. maybe redundant `is_utc` is still needed to use for libical < 3 because it is used internally in libical? Or something wrong with function icaltime_from_timet_with_zone? Successful builds are for distributions that contain libical >= 3 (Buster, Bionic, Cosmic, Disco), failing are all that contain libical < 3. 19 tests fail on older distributions (Squeeze, Wheezy, Lucid, Precise), 13 on newer distributions (same starting from test 443): ``` The following tests FAILED: 61 - testrecurrence__next__data/RecurrenceRule/LibICal/LibICal_TestCase55.ics__ (Failed) 62 - testrecurrence__next__data/RecurrenceRule/LibICal/LibICal_TestCase54.ics__ (Failed) 97 - testrecurrence__next__data/RecurrenceRule/LibICal/LibICal_TestCase15.ics__ (Failed) 204 - testrecurprevious__prev__data/RecurrenceRule/LibICal/LibICal_TestCase55.ics__ (Failed) 205 - testrecurprevious__prev__data/RecurrenceRule/LibICal/LibICal_TestCase54.ics__ (Failed) 240 - testrecurprevious__prev__data/RecurrenceRule/LibICal/LibICal_TestCase15.ics__ (Failed) 443 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase13.vcs__ (Failed) 444 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase12.vcs__ (Failed) 445 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase11.vcs__ (Failed) 446 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase10.vcs__ (Failed) 447 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase09.vcs__ (Failed) 448 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase08.vcs__ (Failed) 449 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase07.vcs__ (Failed) 450 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase06.vcs__ (Failed) 451 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase05.vcs__ (Failed) 452 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase04.vcs__ (Failed) 453 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase03.vcs__ (Failed) 454 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase02.vcs__ (Failed) 455 - readandwrite__ical__data/vCalendar/KOrganizer_vCalTestCase01.vcs__ (Failed) ```

@SlavekB: thanks for testing. Will work on a fix. Most likely the update to libical 3 is resposnsible, as you pointed out. Good thing that the tests have spotted this 😄

Results on Debian 6.0 (Squeeze) and 7.0 (Wheezy):

The following tests FAILED:
         61 - testrecurrence__next__data/RecurrenceRule/LibICal/LibICal_TestCase55.ics__ (Failed)
         62 - testrecurrence__next__data/RecurrenceRule/LibICal/LibICal_TestCase54.ics__ (Failed)
         97 - testrecurrence__next__data/RecurrenceRule/LibICal/LibICal_TestCase15.ics__ (Failed)
        204 - testrecurprevious__prev__data/RecurrenceRule/LibICal/LibICal_TestCase55.ics__ (Failed)
        205 - testrecurprevious__prev__data/RecurrenceRule/LibICal/LibICal_TestCase54.ics__ (Failed)
        240 - testrecurprevious__prev__data/RecurrenceRule/LibICal/LibICal_TestCase15.ics__ (Failed)

Debian 8.0 (Jessie) and newer are fine – the 4XX tests are now resolved. I expect similar results for Ubuntu.

tests seems to be caused by bug in old versions of libical (0.4x) where the DST zone of Los Angeles is inaccurate.

The failing tests refer to a time on April 2, 2002. In 2002 DST was applied on April 7, meaning till that date the time difference between UTC and Los Angeles was 8 hours and not 7. In Squeeze it seems libical thinks it was 7 hours instead of 8.

New commit tested on Squeeze. Looks good.

Building on all currently supported Debian / Ubuntu distributions – only amd64 and i386 for test purposes:

     26 SUCCESS

Tests work fine – good work! However, there is one suggestion for adjustment.

 endforeach( )
 set_target_properties( testfields
  PROPERTIES COMPILE_FLAGS -DINPUT='\"${CMAKE_CURRENT_SOURCE_DIR}/data/test_pilot.ics\"'