TDE
/
tdepim
6
0
Fork 1
Code Issues 23 Pull Requests 4 Releases Wiki Activity
Labels Milestones

KMail: Menu options to toggle "Show Message Structure" - new version #25

Merged
MicheleC merged 2 commits from feat/kmail_toggle_msg into master 5 years ago
Conversation 3 Commits 2 Files Changed 4
MicheleC commented 5 years ago
Owner

This is based on work done by Luke in #19 and is meant to replace that PR.

It includes Luke's second commit and add some changes that make the other two commits not required.

This version does not require the caching of "mIsPlainText", does not require a new slot and most importantly, does not require to re-read the configuration each time a new message is displayed.

Functionality is the same of #19.

Please test before I merge to master.

This is based on work done by Luke in #19 and is meant to replace that PR. It includes Luke's second commit and add some changes that make the other two commits not required.<br> This version does not require the caching of "mIsPlainText", does not require a new slot and most importantly, does not require to re-read the configuration each time a new message is displayed.<br> Functionality is the same of #19. Please test before I merge to master.
MicheleC added this to the R14.1.0 release milestone 5 years ago
SlavekB was assigned by MicheleC 5 years ago
luke-jr was assigned by MicheleC 5 years ago
SlavekB commented 5 years ago
Owner

I tested the building and it seems like a good solution to me.

I tested the building and it seems like a good solution to me.
MicheleC commented 5 years ago
Poster
Owner

Thanks for testing and for feedback Slavek. Since the original PR #19 was proposed by Luke, I will wait for his comments before merging 😄

Thanks for testing and for feedback Slavek. Since the original PR #19 was proposed by Luke, I will wait for his comments before merging :smile:
MicheleC commented 5 years ago
Poster
Owner

Given there has been no feedback from Luke for quite some time (although we have asked both here, in #19 and IRC channel), Slavek and I have agreed to merge this PR.

Given there has been no feedback from Luke for quite some time (although we have asked both here, in #19 and IRC channel), Slavek and I have agreed to merge this PR.
MicheleC closed this pull request 5 years ago
MicheleC deleted branch feat/kmail_toggle_msg 5 years ago
The pull request has been merged as 70cc9c7408.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
SlavekB
luke-jr
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdepim#25
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/kmail_toggle_msg'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes