TDE
/
tdepowersave
6
0
Fork 1
Code Issues 2 Pull Requests 1 Releases Wiki Activity
Labels Milestones
New Issue

Broken UTF8 profile names #4

Closed
opened 4 years ago by chytrex · 4 comments
chytrex commented 4 years ago

Basic information

  • TDE version: 14.1.0
  • Distribution: Devuan ascii
  • Hardware: amd64

Description

When saving profile in TDEpowersave and using international characters (Tried "Výkon 2" as "Výkon" is default in czech localization) profile name got messed up on place where ý should appear. Profile works as expected, I can switch profiles etc.
...

Steps to reproduce

  1. Change settings
  2. Save new profile with international characters in the name of new profile

Screenshots

<!-- This is a comment. Please fill in the required fields below. The comments provide instructions on how to do so. Note: You do not need to remove comments. --> ## Basic information - TDE version: 14.1.0 <!-- such as R14.0.6 - see tde-config -v --> - Distribution: Devuan ascii<!-- such as Debian Stretch - see lsb_release -sd --> - Hardware: amd64<!-- amd64 / i386 / armhf / ... --> <!-- Use SL/* labels to set the severity level. Please do not set a milestone. --> ## Description When saving profile in TDEpowersave and using international characters (Tried "Výkon 2" as "Výkon" is default in czech localization) profile name got messed up on place where ý should appear. Profile works as expected, I can switch profiles etc. ... ## Steps to reproduce 1. Change settings 2. Save new profile with international characters in the name of new profile ## Screenshots <!-- If it seems useful, please provide provide one or more screenshots. -->
chytrex commented 4 years ago
Poster

I investigated it further and suspicious line seems to be:

src/tdepowersave.cpp:214: scheme_menu = new TQPopupMenu(this, i18n("Set Active Scheme").ascii());

As I checked rc file and it seems to have set name correctly.

grep "Výkon" .trinity/share/config/tdepowersaverc
schemes=Performance,Powersave,Presentation,Acoustic,Výkon2
[Výkon2]

I investigated it further and suspicious line seems to be: src/tdepowersave.cpp:214: scheme_menu = new TQPopupMenu(this, i18n("Set Active Scheme").ascii()); As I checked rc file and it seems to have set name correctly. grep "Výkon" .trinity/share/config/tdepowersaverc schemes=Performance,Powersave,Presentation,Acoustic,Výkon2 [Výkon2]
SlavekB commented 4 years ago
Owner

I've found many cases where i18n().ascii() is used – all these cases appear to be wrong. For your case, the culprit is probably tdepowersave.cpp#L1715.

I've found many cases where `i18n().ascii()` is used – all these cases appear to be wrong. For your case, the culprit is probably [tdepowersave.cpp#L1715](src/branch/master/src/tdepowersave.cpp#L1715).
SlavekB added this to the R14.0.7 release milestone 4 years ago
SlavekB added the SL/trivial label 4 years ago
deloptes commented 4 years ago
Collaborator

Aaah again this ascii thing. Thanks - someone will take care next.

Aaah again this ascii thing. Thanks - someone will take care next.
SlavekB commented 4 years ago
Owner

Problem solved by the above commits.

Since KPowerSave has the same problem, I solved it in KPowerSave as well.

Problem solved by the above commits. Since KPowerSave has the same problem, I solved it in KPowerSave as well.
SlavekB closed this issue 4 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
r14.1.x
master
fix/missing_schedutil
r14.0.x
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.7 release
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdepowersave#4
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes