#1 conversion to cmake building system

Merged
SlavekB merged 2 commits from feat/cmakeConv into master 1 year ago
cethyel commented 1 year ago

I had to add #include “tdesudo.moc” to tdesudo.cpp

I’ve added a man page, taken from your debian packaging system and formatted like this:

docbook2x-man tdesudo-trinity.1.docbook

I’ve noticed that I get that error when I type: man tdesudo

Error parsing *roff command from file /usr/share/man/man1/tdesudo.1.gz

This does not bother me since the man pages in Slackware are located in “/usr/man” furthermore, the man page is displayed correctly.

I’ve added tdesu-shared to the linker in the tdesudo/CMakeList.txt since tdesu is requested in the Makefile.am, but It does build without.

I had to add #include "tdesudo.moc" to tdesudo.cpp I've added a man page, taken from your debian packaging system and formatted like this: docbook2x-man tdesudo-trinity.1.docbook I've noticed that I get that error when I type: man tdesudo Error parsing *roff command from file /usr/share/man/man1/tdesudo.1.gz This does not bother me since the man pages in Slackware are located in "/usr/man" furthermore, the man page is displayed correctly. I've added tdesu-shared to the linker in the tdesudo/CMakeList.txt since tdesu is requested in the Makefile.am, but It does build without.
SlavekB commented 1 year ago
Owner

Is the definition of -UTQT_NO_ASCII_CAST for some reason necessary? Or has been forgotten here and can be removed?

Is the definition of `-UTQT_NO_ASCII_CAST` for some reason necessary? Or has been forgotten here and can be removed?
cethyel commented 1 year ago
Poster

I can’t build without it, let me rebuild I’ll show you the error

I can't build without it, let me rebuild I'll show you the error
cethyel commented 1 year ago
Poster
[ 40%] Building CXX object tdesudo/CMakeFiles/tdesudo.dir/tdesudo.cpp.o
/home/cethyel/Public/trinity-pot/CMAKECONV/tdesudo/tdesudo/tdesudo.cpp: In const
ructor 'TdeSudo::TdeSudo(TQWidget*, const char*, const TQString&, const TQString
&, bool)':
/home/cethyel/Public/trinity-pot/CMAKECONV/tdesudo/tdesudo/tdesudo.cpp:137:29: e
rror: cannot convert 'TQString' to 'const char*' for argument '1' to 'char* tqst
rdup(const char*)'
   host = tqstrdup(dcopServer);
                             ^
/home/cethyel/Public/trinity-pot/CMAKECONV/tdesudo/tdesudo/tdesudo.cpp:153:45: e
rror: cannot convert 'TQString' to 'const char*' for argument '2' to 'int setenv
(const char*, const char*, int)'
   setenv("ICEAUTHORITY", iceauthorityFile, 1);
                                             ^
/home/cethyel/Public/trinity-pot/CMAKECONV/tdesudo/tdesudo/tdesudo.cpp:195:24: e
rror: cannot convert 'TQString' to 'const char*' for argument '1' to 'FILE* pope
n(const char*, const char*)'
  if (!(f = popen(c, "r"))) {
                        ^
/home/cethyel/Public/trinity-pot/CMAKECONV/tdesudo/tdesudo/tdesudo.cpp:254:21: e
rror: cannot convert 'TQString' to 'const char*' for argument '1' to 'int atoi(c
onst char*)'
    int intn = atoi(n);
                     ^
/home/cethyel/Public/trinity-pot/CMAKECONV/tdesudo/tdesudo/tdesudo.cpp: In membe
r function 'void TdeSudo::receivedOut(TDEProcess*, char*, int)':
/home/cethyel/Public/trinity-pot/CMAKECONV/tdesudo/tdesudo/tdesudo.cpp:337:12: e
rror: no match for 'operator<<' (operand types are 'std::ostream {aka std::basic
_ostream<char>}' and 'TQString')
  std::cout << strOut << std::endl;
``` [ 40%] Building CXX object tdesudo/CMakeFiles/tdesudo.dir/tdesudo.cpp.o /home/cethyel/Public/trinity-pot/CMAKECONV/tdesudo/tdesudo/tdesudo.cpp: In const ructor 'TdeSudo::TdeSudo(TQWidget*, const char*, const TQString&, const TQString &, bool)': /home/cethyel/Public/trinity-pot/CMAKECONV/tdesudo/tdesudo/tdesudo.cpp:137:29: e rror: cannot convert 'TQString' to 'const char*' for argument '1' to 'char* tqst rdup(const char*)' host = tqstrdup(dcopServer); ^ /home/cethyel/Public/trinity-pot/CMAKECONV/tdesudo/tdesudo/tdesudo.cpp:153:45: e rror: cannot convert 'TQString' to 'const char*' for argument '2' to 'int setenv (const char*, const char*, int)' setenv("ICEAUTHORITY", iceauthorityFile, 1); ^ /home/cethyel/Public/trinity-pot/CMAKECONV/tdesudo/tdesudo/tdesudo.cpp:195:24: e rror: cannot convert 'TQString' to 'const char*' for argument '1' to 'FILE* pope n(const char*, const char*)' if (!(f = popen(c, "r"))) { ^ /home/cethyel/Public/trinity-pot/CMAKECONV/tdesudo/tdesudo/tdesudo.cpp:254:21: e rror: cannot convert 'TQString' to 'const char*' for argument '1' to 'int atoi(c onst char*)' int intn = atoi(n); ^ /home/cethyel/Public/trinity-pot/CMAKECONV/tdesudo/tdesudo/tdesudo.cpp: In membe r function 'void TdeSudo::receivedOut(TDEProcess*, char*, int)': /home/cethyel/Public/trinity-pot/CMAKECONV/tdesudo/tdesudo/tdesudo.cpp:337:12: e rror: no match for 'operator<<' (operand types are 'std::ostream {aka std::basic _ostream<char>}' and 'TQString') std::cout << strOut << std::endl; ```
SlavekB added the
PR/wip
label 1 year ago
SlavekB self-assigned this 1 year ago
SlavekB commented 1 year ago
Owner

Commit 5adfcf05ce addresses the above issues.

The goal is to make a conversion to char* based on where the result is used. For example, for file names and output to console, instead of ascii(), it is preferable to use local8Bit().

Commit 5adfcf05ce addresses the above issues. The goal is to make a conversion to `char*` based on where the result is used. For example, for file names and output to console, instead of `ascii()`, it is preferable to use `local8Bit()`.
SlavekB removed the
PR/wip
label 1 year ago
SlavekB commented 1 year ago
Owner

Merged and pushed upstream.

Merged and pushed upstream.
SlavekB deleted branch feat/cmakeConv 1 year ago
SlavekB added this to the R14.0.6 release milestone 1 year ago
The pull request has been merged.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.