Drop automake build support. #7
Merged
MicheleC
merged 1 commits from drop/automake into master 1 year ago
SlavekB
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'drop/automake'
Deleting a branch is permanent. It CANNOT be undone. Continue?
As per title.
On deb distros, to be built with TDE/tde-packaging#164.
It looks good, but there are two notes about one small thing. See below.
-DCONFIG_INSTALL_DIR="/etc/trinity" \-DSYSCONF_INSTALL_DIR="/etc" \-DXDG_MENU_INSTALL_DIR="/etc/xdg/menus" \-DSUBVERSION_INSTALL_PATH=<subversionlib-install-prefix> \Indentation fixed (sorry for the mistake).
Regarding
SUBVERSION_INSTALL_PATH, I had the same question. It is currently used in ConfigureChecks.cmake to detect svn lib version. We could perhaps rework some of the cmake code to get rid of the code intdesvn/src/svnqt/cmakemodulesbut I think that should be a different PR.I believe that the variable allows users to override the path to the installed Subversion and is designed for cases where the user has a Subversion installed on non-standard location. In other words, it is a option that can be used, but there is no need to use it for normal cases.
You are correct, it is only for special cases. We can either not mention the variable or maybe mentioned separately and an optional one. What do you think?
As far as I know, at present, special cases are not commonly mentioned in these basic information, just as all other
BUILD_...andWITH_...options are not mentioned. Therefore, I think there is no need to mention this option in these basic information.Ok, sounds good. I have removed that line and pushed a force commit.
8074afc301tob12707f7161 year agob12707f716to5d6073d6d91 year agoIt looks good.
5d6073d6d9into master 1 year agoReviewers
5d6073d6d9.