kmilo: added keyboard shortcuts for fine settings of screen brightness. #29

Following up on bug 2783, this PR will add fine control over screen brightness.

I am unable to test it here, so appreciate if someone can test (@deloptes would be great if you could, given you did test previous related PR #21).

Equivalent code for R14.0.10 is available at PR #30.

From bug 2783 comments:

I am unable to test here. With your screen, does 1% changes in brightness result in actual 1% changes? On my home laptop I remember brightness jumping in intervals of 12.5% each, so just curious to know if the fine tuning is useful with other displays.

@whoever tests: please take note of the comment above and make sure to check the functionality.

@MicheleC I am under pressure ATM - I look forward to grab the Dell D520 in the next couple of days and test it - depends on load might be also next weekend in worst case.

@MicheleC I am under pressure ATM - I look forward to grab the Dell D520 in the next couple of days and test it - depends on load might be also next weekend in worst case.

No worries, when you have time 😄

Hi Michele,
I don't remember what was the test case/plan.
Do you remember where we discussed this?
Or if not where did we see the values?
I remember testing brightness up/down and volume up/down.

Is the question here regarding volume or brightness?

Hi Emanoil, the original test was on PR #21 as mentioned on the original comment.

The test here is for fine brightness control from keyboard with Ctrl+XF86MonBrightnessUp and Ctrl+XF86MonBrightnessDown. Basically using Ctrl will enable the fine control of +/- 1% each time, if your monitor support that.

I decided to merge this. The functionality works for Roman and it is a small extension to the existing code, so no harm if noone use the extra functionality.

Good idea, no objections.

Hi Michele,
sorry I could not report back earlier.
For some reason I do not see anywhere values changing, but it seems to be working fine.

Interesting is the fact that in TDEpowersave I have I have 7 steps to move the slider and consistent to that I can press 7 times the brightness up/down keys to change between min and max.

The counter is not changing when I press the buttons, but I must admit I compiled and installed tdeutils with that after all other packages. I don't remember if one would be dependend.

I hope this helps

No problem Emanoil. I think it depends on the display. On my computer I also have a 7 step control, so 1% changes make nothing. But Roman has a different screen and 1% changes are applicable, so there was no harm to add the extra fine control 😄

kmilo: added keyboard shortcuts for fine settings of screen brightness. #29

Reviewers