TDE
/
tdeutils
7
0
Fork 0
Code Issues 6 Pull Requests 2 Releases Wiki Activity
Labels Milestones

WIP: bug#2783: KMilo fixing and expanding to control properly for sound level and brightness into generic monitor #8

Closed
deloptes wants to merge 1 commits from bug/2783/kmilo into master
Conversation 6 Commits 1 Files Changed 2
deloptes commented 5 years ago
Collaborator

This is supplement to bug#2782

KMilo patch for fixing and expanding.

KMilo now in the generic monitor works only for sound volume control but only through DCOP Id "Mixer0" which is not everything as master card used and more, into modern configurations with PulseAudio it newer uses as the master card.

My patch:

  • Fixes crashing KMilo at key "XF86Search" pressing, and all other launching keys.
  • Extend for work with the master card exclusively by the DCOP object Id of KMix "MixerMaster".
  • Extend to control brightness by keys "XF86MonBrightnessUp", "XF86MonBrightnessDown" and through DCOP commands to tdepowersave.

For now I have on my notebook proper work of the shortcut keys with notifications from KMilo about the volume state, level and the brightness level.

This is supplement to bug#2782 KMilo patch for fixing and expanding. KMilo now in the generic monitor works only for sound volume control but only through DCOP Id "Mixer0" which is not everything as master card used and more, into modern configurations with PulseAudio it newer uses as the master card. My patch: - Fixes crashing KMilo at key "XF86Search" pressing, and all other launching keys. - Extend for work with the master card exclusively by the DCOP object Id of KMix "MixerMaster". - Extend to control brightness by keys "XF86MonBrightnessUp", "XF86MonBrightnessDown" and through DCOP commands to tdepowersave. For now I have on my notebook proper work of the shortcut keys with notifications from KMilo about the volume state, level and the brightness level.
MicheleC commented 5 years ago
Owner

Emanoil, thanks for taking the time to create a PR for this bug. Since the original patch is from Roman Savochenko, the commit should indicate him as author :-)

Emanoil, thanks for taking the time to create a PR for this bug. Since the original patch is from Roman Savochenko, the commit should indicate him as author :-)
deloptes commented 5 years ago
Poster
Collaborator

I do not mind. It was just hanging around for too long, so that I decided to push a bit.

I do not mind. It was just hanging around for too long, so that I decided to push a bit.
MicheleC commented 4 years ago
Owner

This PR will not be merged as is. For the brightness part, I have prepared a reworked PR #21. For the mute part, I will take a look in the next few days.

This PR will not be merged as is. For the brightness part, I have prepared a reworked PR #21. For the mute part, I will take a look in the next few days.
deloptes commented 4 years ago
Poster
Collaborator

Great, let me know I can test (at least the mute part).

Also this relates with the kmix patch in TDE/tdemultimedia#4 somehow - I don't remember the details now, but both had to be applied so OSD can work.

Great, let me know I can test (at least the mute part). Also this relates with the kmix patch in TDE/tdemultimedia#4 somehow - I don't remember the details now, but both had to be applied so OSD can work.
MicheleC commented 4 years ago
Owner

Great, let me know I can test (at least the mute part).

Also this relates with the kmix patch in #4 somehow - I don't remember the details now, but both had to be applied so OSD can work.

Hi Emanoil,

you can test #21 for the brightness part, I am waiting for feedback before I merge.

For the mute part I will post here when I am done with it.

> Great, let me know I can test (at least the mute part). > > Also this relates with the kmix patch in #4 somehow - I don't remember the details now, but both had to be applied so OSD can work. > Hi Emanoil,<br/> you can test #21 for the brightness part, I am waiting for feedback before I merge. For the mute part I will post here when I am done with it.
MicheleC commented 4 years ago
Owner

This PR has been obsoleted by PR #26.

This PR has been obsoleted by PR #26.
MicheleC closed this pull request 4 years ago
MicheleC deleted branch bug/2783/kmilo 4 years ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdeutils#8
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'bug/2783/kmilo'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes