TDE
/
tdeutils
7
0
Fork 0
Code Issues 6 Pull Requests 2 Releases Wiki Activity
Labels Milestones

Revive NetBSD support #9

Merged
SlavekB merged 1 commits from feat/revive-netbsd-support into master 5 years ago
Conversation 3 Commits 1 Files Changed 4
obache commented 5 years ago
Collaborator

  • check statvfs(2) support

    • it is conditional but not checked with CMake
    • statfs(2) had been removed since NetBSD-3
    • modern DragonFly BSD should be no issue about statvfs(3)

  • APM support

    • catch up to others changes
    • APM support on NetBSD is not only on i386 but also may emulated on others
* check statvfs(2) support * it is conditional but not checked with CMake * statfs(2) had been removed since NetBSD-3 * modern DragonFly BSD should be no issue about statvfs(3) * APM support * catch up to others changes * APM support on NetBSD is not only on i386 but also may emulated on others
obache commented 5 years ago
Poster
Collaborator

For FilesystemStats in KSIM part,

Even if statvfs exists, getvfsstat may not exists.
Such conditions should be checked individually.

Current usage of getfsstat only get fixed 32 entries.
getfsstat(NULL, 0) will retrun size of entries, so it should be use as
entry buffer size instead, but getmntinfo should make the job easiler.

Incidentally, it seems that KMountPoint in TDECore has same job, collect mounted filesystems, but for different information.

For FilesystemStats in KSIM part, Even if `statvfs` exists, `getvfsstat` may not exists. Such conditions should be checked individually. Current usage of `getfsstat` only get fixed 32 entries. `getfsstat(NULL, 0)` will retrun size of entries, so it should be use as entry buffer size instead, but `getmntinfo` should make the job easiler. Incidentally, it seems that `KMountPoint` in `TDECore` has same job, collect mounted filesystems, but for different information.
obache commented 5 years ago
Poster
Collaborator

Created new PR for KSIM part as #10

Created new PR for KSIM part as #10
obache commented 5 years ago
Poster
Collaborator

change diff to be minimalized

change diff to be minimalized
obache changed title from WIP: Revive NetBSD support to Revive NetBSD support 5 years ago
SlavekB reviewed 5 years ago
SlavekB left a comment
Owner

It looks okay, only there is an unusual thing, please explain it.

It looks okay, only there is an unusual thing, please explain it.
config.h.cmake
#endif // HAVE_MACHIE_APM_BIOS_H
#if !defined( HAVE_DEV_APM_APMIO_H )
#cmakedefine HAVE_DEV_APM_APMIO_H
#endif // HAVE_DEV_APM_APMIO_H
SlavekB commented 5 years ago
Owner

I don't understand why there are conditions instead of simple #cmakedefine?

I don't understand why there are conditions instead of simple `#cmakedefine`?
obache commented 5 years ago
Poster
Collaborator

probably, just copy from the above format.

maybye, it is better to define NetBSD_APM instead.

probably, just copy from the above format. maybye, it is better to define __NetBSD_APM__ instead.
SlavekB commented 5 years ago
Owner

Oh, thank you, I didn't notice that the code above is the same way.

Oh, thank you, I didn't notice that the code above is the same way.
SlavekB closed this pull request 5 years ago
SlavekB deleted branch feat/revive-netbsd-support 5 years ago
SlavekB added this to the R14.0.7 release milestone 5 years ago
The pull request has been merged as f8424834b6.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.7 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdeutils#9
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/revive-netbsd-support'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes