KMilo: added keyboard support for screen brightness up/down. #21

This is inspired and partially include code from Roman Savochenko
proposed in bug 2783 and #8.

I noted that I could test the OSD ... brightness, I am not sure. I have desktop with DVI plugged monitor. I have never tried to control brightness via the keyboard. Need to find out if possible first.

you need tdepowersave installed to test this PR btw. Using the keyboard button for brightness up/down should change the brightness of the screen, as long as this functionality is supported in your system. You can first check in tdepowersave if that is the case.

Hi Michele,
as mentioned I use desktop. It says the hardware does not support this feature. I will try an older notebook that I can boot in TDE later these days.

regards

ok thanks 👍

Hi,
on the Dell D520 it works just fine with OSD showing the level.

Nice!

Note the report in tdemultimedia/pulls/4 - both brightness and mixer work with OSD

Fantastic, thanks for testing. Quick question: when you raise brightness to the max, does the OSD show the number 100% or less? On my laptop I only get to 98% but I know the brightness is at the max. It is either something specific to my laptop or a bug in TDEPowersave.

I don't know. If you want I can test explicitely. I did not memorize the number in the OSD. I think it was 100%, but can not bue sure. Let me know

If you could do a quick check it would be great 😄

Hi Michele,

confirmed it stays at 98% at the max. Interesting how it is calculated.

when decreesing it goes to 0%

Thanks for testing Emanoil. Interesting you get the same value I get. Could you check out something else for additional feedback? Using TDEPowersave or the keyboard shortcut, set the brightness to the max. Then run "dcop tdepowersave tdepowersaveIface brightnessGet" to get the brightness value. On my laptop I get 87%. Do you see the same value?

Hi,

it is weird from dcop I receive -12, OSD says 98% and slider 100%.
Multimedia keys brightness down and it reads -25, -37

OSD 0% = dcop -100

you understand the logic as I do? from -100 to probably 0 in dcop

Fantastic, thanks Emanoil.

-100 means a 100% reduction of brightness, -50 means half reduction, -25 a quarter and so on.

I see exactly the same values on my old notebook. It seems that when brightness is set to the max, TDEPowersave still returns a -12% value. 98% comes from the patch calculation and is in fact a fake value. If TDEPowersave was returning 0, the value would go up to 100%.

It seems there may be a bug in the way TDEPowersave handles brightness value and some investigation is required. I have added this to TDE/tdepowersave#6