WIP: bug#2783: KMilo fixing and expanding to control properly for sound level and brightness into generic monitor #8

Κλειστό
deloptes θέλει να συγχωνεύσει 1 υποβολές από bug/2783/kmilo σε master
deloptes σχολίασε 6 έτη πριν
Συνεργάτης

This is supplement to bug#2782

KMilo patch for fixing and expanding.

KMilo now in the generic monitor works only for sound volume control but only through DCOP Id "Mixer0" which is not everything as master card used and more, into modern configurations with PulseAudio it newer uses as the master card.

My patch:

  • Fixes crashing KMilo at key "XF86Search" pressing, and all other launching keys.
  • Extend for work with the master card exclusively by the DCOP object Id of KMix "MixerMaster".
  • Extend to control brightness by keys "XF86MonBrightnessUp", "XF86MonBrightnessDown" and through DCOP commands to tdepowersave.

For now I have on my notebook proper work of the shortcut keys with notifications from KMilo about the volume state, level and the brightness level.

This is supplement to bug#2782 KMilo patch for fixing and expanding. KMilo now in the generic monitor works only for sound volume control but only through DCOP Id "Mixer0" which is not everything as master card used and more, into modern configurations with PulseAudio it newer uses as the master card. My patch: - Fixes crashing KMilo at key "XF86Search" pressing, and all other launching keys. - Extend for work with the master card exclusively by the DCOP object Id of KMix "MixerMaster". - Extend to control brightness by keys "XF86MonBrightnessUp", "XF86MonBrightnessDown" and through DCOP commands to tdepowersave. For now I have on my notebook proper work of the shortcut keys with notifications from KMilo about the volume state, level and the brightness level.
MicheleC σχολίασε 6 έτη πριν
Ιδιοκτήτης

Emanoil, thanks for taking the time to create a PR for this bug. Since the original patch is from Roman Savochenko, the commit should indicate him as author :-)

Emanoil, thanks for taking the time to create a PR for this bug. Since the original patch is from Roman Savochenko, the commit should indicate him as author :-)
deloptes σχολίασε 6 έτη πριν
Συντάκτης
Συνεργάτης

I do not mind. It was just hanging around for too long, so that I decided to push a bit.

I do not mind. It was just hanging around for too long, so that I decided to push a bit.
MicheleC σχολίασε 4 έτη πριν
Ιδιοκτήτης

This PR will not be merged as is. For the brightness part, I have prepared a reworked PR #21. For the mute part, I will take a look in the next few days.

This PR will not be merged as is. For the brightness part, I have prepared a reworked PR #21. For the mute part, I will take a look in the next few days.
deloptes σχολίασε 4 έτη πριν
Συντάκτης
Συνεργάτης

Great, let me know I can test (at least the mute part).

Also this relates with the kmix patch in TDE/tdemultimedia#4 somehow - I don't remember the details now, but both had to be applied so OSD can work.

Great, let me know I can test (at least the mute part). Also this relates with the kmix patch in TDE/tdemultimedia#4 somehow - I don't remember the details now, but both had to be applied so OSD can work.
MicheleC σχολίασε 4 έτη πριν
Ιδιοκτήτης

Great, let me know I can test (at least the mute part).

Also this relates with the kmix patch in #4 somehow - I don't remember the details now, but both had to be applied so OSD can work.

Hi Emanoil,

you can test #21 for the brightness part, I am waiting for feedback before I merge.

For the mute part I will post here when I am done with it.

> Great, let me know I can test (at least the mute part). > > Also this relates with the kmix patch in #4 somehow - I don't remember the details now, but both had to be applied so OSD can work. > Hi Emanoil,<br/> you can test #21 for the brightness part, I am waiting for feedback before I merge. For the mute part I will post here when I am done with it.
MicheleC σχολίασε 4 έτη πριν
Ιδιοκτήτης

This PR has been obsoleted by PR #26.

This PR has been obsoleted by PR #26.
MicheleC έκλεισε αυτό το pull request 4 έτη πριν
MicheleC διέγραψε το κλάδο bug/2783/kmilo 4 έτη πριν
Αυτό το pull request δεν μπορεί να ανοίξει ξανά επειδή ο κλάδος διαγράφηκε.
Συνδεθείτε για να συμμετάσχετε σε αυτή τη συνομιλία.
Δεν υπάρχουν εξεταστές
Χωρίς Ορόσημο
Χωρίς Αποδέκτη
2 Συμμετέχοντες
Ειδοποιήσεις
Ημερομηνία Παράδοσης

Δεν ορίστηκε ημερομηνία παράδοσης.

Εξαρτήσεις

Δεν έχουν οριστεί εξαρτήσεις.

Αναφορά: TDE/tdeutils#8
Φόρτωση…
Δεν υπάρχει ακόμα περιεχόμενο.