kdevdesigner: prevent SEGV from invalid pointer. This relates to issue TDE/tqt3#97 #35

Merged
MicheleC merged 1 commits from fix/prevent-segv into master 5 months ago
Owner

@ormorph this is a similar fix for tdevelop. Can you also test this one?

@ormorph this is a similar fix for tdevelop. Can you also test this one?
MicheleC added this to the R14.1.2 release milestone 5 months ago
MicheleC added 1 commit 5 months ago
MicheleC requested review from Core 5 months ago
MicheleC requested review from Owners 5 months ago
MicheleC requested review from ormorph 5 months ago
MicheleC force-pushed fix/prevent-segv from f1c48d3238 to 30ac86e18c 5 months ago
Collaborator

These changes are certainly necessary, but they do not solve the problem of creating the form. In this case, there is another error when creating the form.
Program received signal SIGSEGV, Segmentation fault.

MetaDataBase::includes (o=0x4830f45ca0e661da) at ./kdevdesigner/designer/metadatabase.cpp:1078
warning: Source file is more recent than executable.
1078		tqWarning( "No entry for %p (%s, %s) found in MetaDataBase",

I will add the full window crash output using gdb later. If you check the error directly in gdb, the output will be cleaner. For now, I’m posting the error log obtained directly using TDE.
However, we can still make these changes in kdevdesigner, they are also necessary.

These changes are certainly necessary, but they do not solve the problem of creating the form. In this case, there is another error when creating the form. Program received signal SIGSEGV, Segmentation fault. ``` MetaDataBase::includes (o=0x4830f45ca0e661da) at ./kdevdesigner/designer/metadatabase.cpp:1078 warning: Source file is more recent than executable. 1078 tqWarning( "No entry for %p (%s, %s) found in MetaDataBase", ``` I will add the full window crash output using gdb later. If you check the error directly in gdb, the output will be cleaner. For now, I’m posting the error log obtained directly using TDE. However, we can still make these changes in kdevdesigner, they are also necessary.
Collaborator

The gdb error output from the source directory.
This still needs to be dealt with; a null pointer is also passed here.

The gdb error output from the source directory. This still needs to be dealt with; a null pointer is also passed here.
Poster
Owner

Ok, I will merge this PR and link this to TDE/tdevelop#17, which is an issue for TDevelop crash (maybe the same?)

Ok, I will merge this PR and link this to TDE/tdevelop#17, which is an issue for TDevelop crash (maybe the same?)
MicheleC merged commit 30ac86e18c into master 5 months ago
MicheleC deleted branch fix/prevent-segv 5 months ago
Collaborator

which is an issue for TDevelop crash (maybe the same?)

A failure occurs when attempting to create any form. It doesn't even get to the point of adding elements to the form. We still need to figure this out, it’s clear that null pointers are being added, but the reason itself still needs to be found.

> which is an issue for TDevelop crash (maybe the same?) A failure occurs when attempting to create any form. It doesn't even get to the point of adding elements to the form. We still need to figure this out, it’s clear that null pointers are being added, but the reason itself still needs to be found.
Poster
Owner

A failure occurs when attempting to create any form. It doesn't even get to the point of adding elements to the form. We still need to figure this out, it’s clear that null pointers are being added, but the reason itself still needs to be found.

Yes, but please report on issue #17 not here. This was a simple PR to implement the same fix done in TDE/tqt3#99. This PR is not meant to solve all crashes, so we should use issue #17 to track the problem, for better clarity.

> A failure occurs when attempting to create any form. It doesn't even get to the point of adding elements to the form. We still need to figure this out, it’s clear that null pointers are being added, but the reason itself still needs to be found. Yes, but please report on issue #17 not here. This was a simple PR to implement the same fix done in TDE/tqt3#99. This PR is not meant to solve all crashes, so we should use issue #17 to track the problem, for better clarity.
Poster
Owner

Or if the problem is different from issue #17, then let's create a new issue for that :-)

Or if the problem is different from issue #17, then let's create a new issue for that :-)

Reviewers

ormorph was requested for review 5 months ago
TDE/Core was requested for review 5 months ago
TDE/Owners was requested for review 5 months ago
The pull request has been merged as 30ac86e18c.
Sign in to join this conversation.
No reviewers
TDE/Core
TDE/Owners
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdevelop#35
Loading…
There is no content yet.