Labels Milestones

Quanta: Creating tarballs for toolbars during building #3

Merged

SlavekB merged 1 commits from feat/toolbarsTarballs into master 5 years ago

Conversation 0 Commits 1 Files Changed 40

SlavekB commented 5 years ago

Owner

On tde-devs we talked that there was no reason to include tarballs in the source code, where these tarballs contain source XML files. We have confirmed that it makes sense to have these source XML files in source code and tarballs were created during building.

After preparing the CMake rules, I realized that tdewebdev are built using Automake, so I have prepared the Automake rules. Now everything should work as intended.

On tde-devs we talked that there was no reason to include tarballs in the source code, where these tarballs contain source XML files. We have confirmed that it makes sense to have these source XML files in source code and tarballs were created during building. After preparing the CMake rules, I realized that tdewebdev are built using Automake, so I have prepared the Automake rules. Now everything should work as intended.

SlavekB added the PR/rfc label 5 years ago

SlavekB removed the PR/rfc label 5 years ago

SlavekB closed this pull request 5 years ago

SlavekB deleted branch feat/toolbarsTarballs 5 years ago

SlavekB added this to the R14.0.6 release milestone 5 years ago

The pull request has been merged as 915b786429.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Milestone

Set milestone

Clear milestone

No items

No Milestone

R14.0.6 release

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdewebdev#3

Write Preview

Loading…

Cancel

Save

There is no content yet.